Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Only print "gclient sync" warning once during rebase #52133

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Only print "gclient sync" warning once during rebase #52133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/githooks/lib/src/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const String _reset = '\x1B[0m';
/// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when
/// stdout supports ANSI escape codes.
void printGclientSyncReminder(String command) {
if (command == 'pre-rebase') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cleaner to just remove the call to this function from https://github.com/flutter/engine/blob/main/tools/githooks/lib/src/pre_rebase_command.dart#L19, I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that would be better, let me fix it. Thanks @zanderso

return;
}
final String prefix = io.stdout.supportsAnsiEscapes ? _redBoldUnderline : '';
final String postfix = io.stdout.supportsAnsiEscapes ? _reset : '';
io.stderr.writeln('$command: The engine source tree has been updated.');
Expand Down