Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [skwasm] Fix platform view placement. #54870

Merged
merged 5 commits into from
Sep 11, 2024
Merged

[CP] [skwasm] Fix platform view placement. #54870

merged 5 commits into from
Sep 11, 2024

Conversation

Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Aug 29, 2024 •
edited
Loading

Cherry-pick of #53845

@eyebrowsoffire @Rexios80
[skwasm] Fix platform view placement. (flutter#53845)
d59c581 
Previously, each platform view contained styling/placement information from the entire stack of the layer builder. This caused issues when using `addRetained`, since it would contain stale styling/placement information from its old parent layers. I have changed it so that platform views only contain local styling information, and that styling is combined with the parent only when the layers are merged.
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 29, 2024
@Rexios80 Rexios80 mentioned this pull request Aug 29, 2024
Closed
@Rexios80 Rexios80 changed the title [CP] Fix platform view placement for web WASM builds [CP] [skwasm] Fix platform view placement. Aug 29, 2024
@Rexios80
Copy link
Member Author

Rexios80 commented Sep 4, 2024

@eyebrowsoffire Any thoughts on this one? Also there was just a release. Does that mean the target branch should change on these PRs?

eyebrowsoffire
eyebrowsoffire approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Again, not sure about the release branch stuff, hopefully someone on the release team will clarify if that needs to be changed).

@Rexios80 Rexios80 added cp: stable cherry pick to the stable release candidate branch cp: review add the cp request to the review queue of release engineers labels Sep 5, 2024
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2024
@auto-submit auto-submit bot merged commit 4b76ac4 into flutter:flutter-3.24-candidate.0 Sep 11, 2024
26 checks passed
@itsjustkevin itsjustkevin mentioned this pull request Sep 11, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 11, 2024
@itsjustkevin
[flutter_releases] Flutter stable 3.24.3 Engine Cherrypicks (#55108)
3633501 
# Flutter stable 3.24.3 Engine

## Scheduled Cherrypicks

- Roll dart revision: dart-lang/sdk@179da3ba6
- #54842
- #54843
- #54871
- #54870
- #54942
- #55007
- #55056
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review add the cp request to the review queue of release engineers cp: stable cherry pick to the stable release candidate branch platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rexios80 @eyebrowsoffire @itsjustkevin