Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[android] Disable AHB swapchain and import on huawei API 29 devices. #54879

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

jonahwilliams
Copy link
Member

From local testing, it seems that AHB imports and swapchain usage of AHBs does not work on these Huawei devices. Vulkan does seem to work OK with these optional features disabled, but so far we've only tested on the P40 Pro.

Fixes flutter/flutter#154068

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit auto-submit bot merged commit da87db6 into flutter:main Aug 30, 2024
34 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2024
…154381)

flutter/engine@dc7eefb...da87db6

2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879)
2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#154381)

flutter/engine@dc7eefb...da87db6

2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879)
2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@umutarpat
Copy link

umutarpat commented Nov 25, 2024

Hi, Any news on when this will be in Flutter stable channel or if it is already in stable channel can I get the information on which version is it. Thank you.

@matanlurey @chinmaygarde @jonahwilliams

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video player on Huawei Android 29 device does not play media
3 participants