Hooks up framework wide gamut to engine wide gamut #54567

gaaclarke · 2024-08-15T15:54:58Z

issue: flutter/flutter#127855
integration test: #54415

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

issue: flutter/flutter#127855 integration test: #54415 This is the engine side changes required for wide gamut framework support. It changes the internal representation of DlColor to be floats. It will be married with #54415 when it lands in #54567. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Reverts: #54473 Initiated by: jonahwilliams Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue Original PR Author: gaaclarke Reviewed By: {flar} This change reverts the following previous change: issue: flutter/flutter#127855 integration test: #54415 This is the engine side changes required for wide gamut framework support. It changes the internal representation of DlColor to be floats. It will be married with #54415 when it lands in #54567. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

issue: flutter/flutter#127855 integration test: flutter#54415 This is the engine side changes required for wide gamut framework support. It changes the internal representation of DlColor to be floats. It will be married with flutter#54415 when it lands in flutter#54567. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

relands #54473 issue: flutter/flutter#127855 integration test: #54415 This is the engine side changes required for wide gamut framework support. It changes the internal representation of DlColor to be floats. It will be married with #54415 when it lands in #54567. ## Difference from last attempt 1) The default color is now opaque black, not transparent black (not the issue for revert) 1) Updated a test to send in valid numbers when constructing a color and added asserts to avoid those problems in the future. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

flutter-dashboard · 2024-08-22T21:10:39Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #54567 at sha 4956584

gaaclarke · 2024-08-22T21:27:45Z

Running the opengles test locally in playgrounds with angle produces a valid image:

Same with golden images test:

jonahwilliams

LGTM

gaaclarke · 2024-08-22T22:02:06Z

I put a breakpoint on this code and that test DrawVerticesWithInvalidIndices never hits this. I think we may have a flakey golden?

jonahwilliams · 2024-08-22T22:41:59Z

If its just for GLES lets disable it?

gaaclarke · 2024-08-22T22:42:57Z

If its just for GLES lets disable it?

I'm waiting to see if it happens again. Now I keep getting time outs on the mac tests after having rebased =T

gaaclarke · 2024-08-22T22:52:34Z

If it happens again I'll disable it. If it doesn't happen again I'll file an issue. It could be 1/1,000,000 in which case we can probably leave it for now.

issue: flutter/flutter#127855 integration test: flutter#54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: flutter#54714 Here are follow up PRs: 1) flutter#54473 - changes DlColor so the wide gamut colors are rendered 1) flutter#54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

[This PR](#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

impeller/display_list/aiks_dl_vertices_unittests.cc

jonahwilliams

LGTM, thank you!

jonahwilliams · 2024-08-29T22:18:01Z

lib/ui/painting/paint.cc

-      static_cast<uint8_t>(std::round(blue * 255.f)) << 0;
-  // TODO(gaaclarke): Pass down color info to DlColor.
-  return DlColor(encoded_color);
+  return DlColor(alpha, red, green, blue,


Shower thought, don't we need to do any color space conversions to RGBA/extend RGBA here? Or should we do that in dispatch based on the destination surface?

The last PR added DlColor::withColorSpace for this conversion. The next PR is an integration test that makes sure everything works. It's been a couple of weeks since I tested the whole flow. It's possible it got lost in all this juggling. Let me double check I didn't lose it, because I'm not seeing a call to DlColor::withColorSpace anymore.

You are correct, sir, reintroduced. When's that monorepo coming again?

jonahwilliams · 2024-08-29T22:34:51Z

lib/ui/painting/paint.cc

+  DlColor dl_color(alpha, red, green, blue,
+                   static_cast<DlColorSpace>(colorspace));
+
+  return dl_color.withColorSpace(DlColorSpace::kExtendedSRGB);


I think you also need the gradient conversions too, right?

You're jumping ahead, that happens in #54748.

The conversion happens in a different place for gradients. It was easier to do it in dart for them. We can reevaluate after we get our integration tests landed. It's ideal to do the conversion in c++.

I think that you need to move it into the engine eventually so that we can handle android, which may have a displayP3 color space and not an extended srgb space.

jonahwilliams

LGTM

…/engine#54567)

…154381) flutter/engine@dc7eefb...da87db6 2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879) 2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

chingjun · 2024-08-30T04:22:31Z

Reason for revert: Breaking internal tests. See b/363125155

This reverts commit e3a15e1.

…#54884) Reverts: #54567 Initiated by: chingjun Reason for reverting: Breaking internal tests. See b/363125155 Original PR Author: gaaclarke Reviewed By: {jonahwilliams, chinmaygarde} This change reverts the following previous change: issue: flutter/flutter#127855 integration test: #54415 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Reverts: #54737 Initiated by: chingjun Reason for reverting: Breaking internal tests. See b/363125155 Original PR Author: gaaclarke Reviewed By: {matanlurey, jonahwilliams} This change reverts the following previous change: [This PR](#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

[This PR](flutter#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: flutter#54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: flutter#54714 Here are follow up PRs: 1) flutter#54473 - changes DlColor so the wide gamut colors are rendered 1) flutter#54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

issue: flutter/flutter#127855 integration test: flutter#54415 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

[This PR](#54415) was reverted because it required customer testing updates. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Reland 2 notes This was reverted because it changes the math on `_lerpDouble`. While those changes were mathematcially equivalent, they had different behaviors when working with non-numbers which created unexpected changes. The change has been reverted and a test added. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

issue: flutter/flutter#127855 integration test: flutter#54415 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

relands #54567 depends on #54905 This was reverted because the PR that it depends on was reverted. There is nothing to be addressed here. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…lutter#154381) flutter/engine@dc7eefb...da87db6 2024-08-30 [email protected] [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879) 2024-08-29 [email protected] Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the platform-web Code specifically for the web engine label Aug 15, 2024

gaaclarke mentioned this pull request Aug 15, 2024

Changes DlColor to support wide gamut colors #54473

Merged

8 tasks

auto-submit bot mentioned this pull request Aug 20, 2024

Reverts "Changes DlColor to support wide gamut colors (#54473)" #54636

Merged

8 tasks

gaaclarke mentioned this pull request Aug 20, 2024

Changes DlColor to support wide gamut colors (#54473) #54648

Merged

8 tasks

gaaclarke mentioned this pull request Aug 22, 2024

Framework wide color #54415

Merged

8 tasks

gaaclarke force-pushed the framework-wide-color-marriage branch from b2132f9 to 4956584 Compare August 22, 2024 20:11

gaaclarke marked this pull request as ready for review August 22, 2024 20:19

flutter-dashboard bot added the will affect goldens label Aug 22, 2024

gaaclarke force-pushed the framework-wide-color-marriage branch from 4956584 to 85418d4 Compare August 22, 2024 21:22

gaaclarke requested review from chinmaygarde and jonahwilliams August 22, 2024 21:28

chinmaygarde approved these changes Aug 22, 2024

View reviewed changes

jonahwilliams approved these changes Aug 22, 2024

View reviewed changes

gaaclarke force-pushed the framework-wide-color-marriage branch from 85418d4 to 4956584 Compare August 22, 2024 22:44

gaaclarke mentioned this pull request Aug 23, 2024

Reland: Framework wide color (#54415) #54737

Merged

8 tasks

Hooks up framework wide gamut color to the engine.

647a030

jonahwilliams reviewed Aug 29, 2024

View reviewed changes

impeller/display_list/aiks_dl_vertices_unittests.cc Outdated Show resolved Hide resolved

jonah feedback

555c462

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024

jonahwilliams approved these changes Aug 29, 2024

View reviewed changes

jonahwilliams reviewed Aug 29, 2024

View reviewed changes

gaaclarke removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024

brought back the colorspace conversion

0a90ec7

jonahwilliams reviewed Aug 29, 2024

View reviewed changes

jonahwilliams approved these changes Aug 29, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024

auto-submit bot merged commit e3a15e1 into flutter:main Aug 29, 2024
32 checks passed

engine-flutter-autoroll mentioned this pull request Aug 30, 2024

Roll Flutter Engine from dc7eefb0f18a to da87db6d55e3 (2 revisions) flutter/flutter#154381

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2024

e3a15e145 Hooks up framework wide gamut to engine wide gamut (flutter…

267f607

…/engine#54567)

chingjun added the revert Label used to revert changes in a closed and merged pull request. label Aug 30, 2024

auto-submit bot pushed a commit that referenced this pull request Aug 30, 2024

Revert "Hooks up framework wide gamut to engine wide gamut (#54567)"

2f86215

This reverts commit e3a15e1.

auto-submit bot mentioned this pull request Aug 30, 2024

Reverts "Hooks up framework wide gamut to engine wide gamut (#54567)" #54884

Merged

8 tasks

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Aug 30, 2024

auto-submit bot mentioned this pull request Aug 30, 2024

Reverts "Reland: Framework wide color (#54415) (#54737)" #54885

Merged

8 tasks

gaaclarke mentioned this pull request Aug 30, 2024

Reland: Framework wide color (#54415) (#54737) #54905

Merged

8 tasks

gaaclarke mentioned this pull request Aug 30, 2024

Reland: Hooks up framework wide gamut to engine wide gamut #54906

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hooks up framework wide gamut to engine wide gamut #54567

Hooks up framework wide gamut to engine wide gamut #54567

gaaclarke commented Aug 15, 2024 •

edited

Loading

flutter-dashboard bot commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

jonahwilliams left a comment

gaaclarke commented Aug 22, 2024

jonahwilliams commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

jonahwilliams left a comment

jonahwilliams Aug 29, 2024

gaaclarke Aug 29, 2024

gaaclarke Aug 29, 2024

jonahwilliams Aug 29, 2024

gaaclarke Aug 29, 2024

gaaclarke Aug 29, 2024

jonahwilliams Aug 29, 2024

jonahwilliams left a comment

chingjun commented Aug 30, 2024

Hooks up framework wide gamut to engine wide gamut #54567

Hooks up framework wide gamut to engine wide gamut #54567

Conversation

gaaclarke commented Aug 15, 2024 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

jonahwilliams left a comment

Choose a reason for hiding this comment

gaaclarke commented Aug 22, 2024

jonahwilliams commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

gaaclarke commented Aug 22, 2024

jonahwilliams left a comment

Choose a reason for hiding this comment

jonahwilliams Aug 29, 2024

Choose a reason for hiding this comment

gaaclarke Aug 29, 2024

Choose a reason for hiding this comment

gaaclarke Aug 29, 2024

Choose a reason for hiding this comment

jonahwilliams Aug 29, 2024

Choose a reason for hiding this comment

gaaclarke Aug 29, 2024

Choose a reason for hiding this comment

gaaclarke Aug 29, 2024

Choose a reason for hiding this comment

jonahwilliams Aug 29, 2024

Choose a reason for hiding this comment

jonahwilliams left a comment

Choose a reason for hiding this comment

chingjun commented Aug 30, 2024

gaaclarke commented Aug 15, 2024 •

edited

Loading