-
Notifications
You must be signed in to change notification settings - Fork 6k
Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896)" #54901
Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896)" #54901
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
…154416) flutter/engine@9c3f66d...c851c58 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (#54886)" (flutter/engine#54902) 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896)" (flutter/engine#54901) 2024-08-30 [email protected] Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896) 2024-08-30 [email protected] Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891) 2024-08-30 [email protected] Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890) 2024-08-30 [email protected] Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889) 2024-08-30 [email protected] Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#154416) flutter/engine@9c3f66d...c851c58 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter#54886)" (flutter/engine#54902) 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter#54896)" (flutter/engine#54901) 2024-08-30 [email protected] Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896) 2024-08-30 [email protected] Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891) 2024-08-30 [email protected] Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890) 2024-08-30 [email protected] Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889) 2024-08-30 [email protected] Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Reverts: #54896
Initiated by: zanderso
Reason for reverting: Reverting Dart rolls for an issue with
dart fix
.Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/88d311c9a531..995324d1b218
2024-08-30 [email protected] Version 3.6.0-200.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md