Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (#54886)" #54902

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Aug 30, 2024

Reverts: #54886

Initiated by: zanderso

Reason for reverting: An issue with dart fix is failing the roll to the framework.

Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/139867e57ba9..88d311c9a531

2024-08-30 [email protected] Version 3.6.0-199.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Aug 30, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@auto-submit auto-submit bot merged commit c851c58 into main Aug 30, 2024
7 checks passed
@auto-submit auto-submit bot deleted the revert_0e5df26e590ff0a4d2e9be8f7b3bedea8bd97db3 branch August 30, 2024 14:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2024
…154416)

flutter/engine@9c3f66d...c851c58

2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (#54886)" (flutter/engine#54902)
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896)" (flutter/engine#54901)
2024-08-30 [email protected] Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896)
2024-08-30 [email protected] Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891)
2024-08-30 [email protected] Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890)
2024-08-30 [email protected] Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889)
2024-08-30 [email protected] Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#154416)

flutter/engine@9c3f66d...c851c58

2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter#54886)" (flutter/engine#54902)
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter#54896)" (flutter/engine#54901)
2024-08-30 [email protected] Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896)
2024-08-30 [email protected] Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891)
2024-08-30 [email protected] Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890)
2024-08-30 [email protected] Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889)
2024-08-30 [email protected] Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants