This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Hooks up framework wide gamut to engine wide gamut #54906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-web
gaaclarke
changed the title
issue: flutter/flutter#127855 integration test: flutter#54415 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gaaclarke
force-pushed
the
reland-e3a15e145e7c5ca336cc7d969d596bcae7eee961
branch
from
5c7582e to
f31a13b
Compare
gaaclarke
changed the title
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2024
…154451) flutter/engine@eff1b76...4f1de98 2024-08-30 [email protected] Roll Skia from 0182585d38dd to 9d0039785ebd (4 revisions) (flutter/engine#54910) 2024-08-30 [email protected] Roll Skia from 2727e4e5d7ec to 0182585d38dd (1 revision) (flutter/engine#54908) 2024-08-30 [email protected] Reland: Hooks up framework wide gamut to engine wide gamut (flutter/engine#54906) 2024-08-30 [email protected] Roll Fuchsia Linux SDK from ohUS2y1HixZYziUtX... to JKPo9G1NaAdstrimW... (flutter/engine#54907) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ohUS2y1HixZY to JKPo9G1NaAds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#154451) flutter/engine@eff1b76...4f1de98 2024-08-30 [email protected] Roll Skia from 0182585d38dd to 9d0039785ebd (4 revisions) (flutter/engine#54910) 2024-08-30 [email protected] Roll Skia from 2727e4e5d7ec to 0182585d38dd (1 revision) (flutter/engine#54908) 2024-08-30 [email protected] Reland: Hooks up framework wide gamut to engine wide gamut (flutter/engine#54906) 2024-08-30 [email protected] Roll Fuchsia Linux SDK from ohUS2y1HixZYziUtX... to JKPo9G1NaAdstrimW... (flutter/engine#54907) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ohUS2y1HixZY to JKPo9G1NaAds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relands #54567
depends on #54905
This was reverted because the PR that it depends on was reverted. There is nothing to be addressed here.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.