Wire up the Skia persistent GPU related artifacts cache. #6278

chinmaygarde · 2018-09-18T23:41:12Z

Also teaches FML to create files and directories.

chinmaygarde · 2018-09-19T01:07:24Z

@jason-simmons & I discussed offline that conflating files and directories in the Open call (along with optionally creating them) is a confusing. Adding a separate path for directories.

fml/file_unittest.cc

jason-simmons · 2018-09-20T00:43:59Z

fml/platform/posix/file_posix.cc

-    case OpenPermission::kExecute:
-      flags = O_RDONLY;
+    case FilePermission::kExecute:
+      mode |= 0;


This is a no-op. I would expect kExecute to set the S_IXUSR bit

Actually, I think kExecute should be removed from the FilePermission enum

Callers should not create executable files, and I'd prefer not to overload FilePermission to signal whether a file mapping should have PROT_EXEC

jason-simmons · 2018-09-20T00:46:24Z

fml/platform/posix/file_posix.cc

+fml::UniqueFD OpenFile(const char* path,
+                       bool create_if_necessary,
+                       FilePermission permission) {
+  return OpenFile(fml::UniqueFD{AT_FDCWD}, path, create_if_necessary,


Does UniqueFD need to special case fake FDs like AT_FDCWD?

It might be simpler to always have UniqueFD wrap a real FD. FML could then have a private version of OpenFile that takes an int (including AT_FDCWD) and a public version that takes the UniqueFD& and extracts the file descriptor

AT_FDCWD is not in the valid ranges for a FD. So outside of this internal method, is_valid for an AT_FDCWD will return false. Also, we never vend one of these outside this file to callers.

fml/platform/posix/file_posix.cc

shell/common/persistent_cache.cc

jason-simmons · 2018-09-20T01:16:40Z

fml/platform/posix/file_posix.cc

+
+  if (create_if_necessary && !FileExists(base_directory, path)) {
+    flags = ToPosixAccessFlags(permission) | O_CREAT | O_TRUNC;
+    mode = ToPosixCreateModeFlags(permission);


Would the create mode flags ever be anything other than (S_IRUSR | S_IWUSR)?

It might be simpler to eliminate ToPosixCreateModeFlags and always use read/write for newly created files and read/write/execute for newly created directories

chinmaygarde · 2018-09-21T02:25:01Z

Cache hits are serviced in ~0.2ms which is a great improvement. Cache stores however need to be written atomically to the filesystem and take ~3-8ms. This is in addition to the work necessary to create the resources to be cached in the first place. In a future patch, I will move the stores to the IO thread. This is currently not possible PersistentCache is shared by all engines in the process and the IO thread for the engine may not yet be setup.

Cache.json.zip

gubaojian

good

Also teaches FML to create files and directories.

flutter/engine@38a646e...26fdd1e git log 38a646e..26fdd1e --no-merges --oneline 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...309ac4e git log 38a646e..309ac4e --no-merges --oneline 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...5b79938 git log 38a646e..5b79938 --no-merges --oneline 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...2dd9b99 git log 38a646e..2dd9b99 --no-merges --oneline 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...075b3fc git log 38a646e..075b3fc --no-merges --oneline 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...c589b31 git log 38a646e..c589b31 --no-merges --oneline c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...b8c2a17 git log 38a646e..b8c2a17 --no-merges --oneline b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@38a646e...3052dbd git log 38a646e..3052dbd --no-merges --oneline 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) 9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348) ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315) a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346) d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344) 0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345) e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343) bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342) a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331) 5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340) 6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338) a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336) 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@9d4b80a...5ae4708 git log 9d4b80a..5ae4708 --no-merges --oneline 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@9d4b80a...3a01f39 git log 9d4b80a..3a01f39 --no-merges --oneline 3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361) 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@9d4b80a...edf6249 git log 9d4b80a..edf6249 --no-merges --oneline edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349) 3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361) 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@9d4b80a...d80c1de git log 9d4b80a..d80c1de --no-merges --oneline d80c1de Roll src/third_party/skia ab3144c3abb9..656cefe65d62 (11 commits) (flutter/engine#6362) edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349) 3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361) 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

Also teaches FML to create files and directories.

chinmaygarde requested a review from jason-simmons September 18, 2018 23:41

googlebot added the cla: yes label Sep 18, 2018

jason-simmons approved these changes Sep 19, 2018

View reviewed changes

jason-simmons reviewed Sep 20, 2018

View reviewed changes

jason-simmons approved these changes Sep 20, 2018

View reviewed changes

gubaojian reviewed Sep 22, 2018

View reviewed changes

chinmaygarde force-pushed the persistent_cache branch 7 times, most recently from 4fd7f46 to b4402fa Compare September 26, 2018 20:26

Wire up the Skia persistent GPU related artifacts cache.

1af78e9

Also teaches FML to create files and directories.

chinmaygarde force-pushed the persistent_cache branch from b4402fa to 1af78e9 Compare September 26, 2018 20:34

Licenses

5c42da4

chinmaygarde merged commit f2a3df9 into flutter:master Sep 26, 2018

chinmaygarde deleted the persistent_cache branch September 26, 2018 21:54

chinmaygarde mentioned this pull request Sep 26, 2018

Perform persistent cache stores on the IO thread outside the frame workload. #6350

Merged

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..26fdd1e4fa0c (16 commits) flutter/flutter#22329

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..309ac4e1bee0 (17 commits) flutter/flutter#22331

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..5b799381f448 (18 commits) flutter/flutter#22332

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..2dd9b99aa693 (19 commits) flutter/flutter#22334

Closed

This was referenced Sep 27, 2018

Roll engine 38a646e14cc2..075b3fcca8c7 (20 commits) flutter/flutter#22335

Closed

Roll engine 38a646e14cc2..c589b312a9fd (21 commits) flutter/flutter#22339

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..b8c2a17a15a8 (22 commits) flutter/flutter#22341

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 38a646e14cc2..3052dbd79bdc (24 commits) flutter/flutter#22357

Closed

This was referenced Sep 27, 2018

Roll engine 9d4b80a60cb5..5ae47084524a (13 commits) flutter/flutter#22364

Closed

Roll engine 9d4b80a60cb5..3a01f395685a (14 commits) flutter/flutter#22365

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 9d4b80a60cb5..edf6249e07bb (15 commits) flutter/flutter#22367

Closed

engine-flutter-autoroll mentioned this pull request Sep 27, 2018

Roll engine 9d4b80a60cb5..d80c1de7b53a (16 commits) flutter/flutter#22374

Closed

GaryQian pushed a commit to GaryQian/engine that referenced this pull request Oct 2, 2018

Wire up the Skia persistent GPU related artifacts cache. (flutter#6278)

df2fed0

Also teaches FML to create files and directories.

mklim mentioned this pull request Nov 12, 2018

Unable to run demo twice at the same virtual device flutter/flutter#24058

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wire up the Skia persistent GPU related artifacts cache. #6278

Wire up the Skia persistent GPU related artifacts cache. #6278

Uh oh!

chinmaygarde commented Sep 18, 2018

Uh oh!

chinmaygarde commented Sep 19, 2018

Uh oh!

Uh oh!

jason-simmons Sep 20, 2018

Uh oh!

jason-simmons Sep 20, 2018 •

edited

Loading

Uh oh!

chinmaygarde Sep 20, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jason-simmons Sep 20, 2018

Uh oh!

chinmaygarde commented Sep 21, 2018 •

edited

Loading

Uh oh!

gubaojian left a comment •

edited

Loading

Uh oh!

Uh oh!

Wire up the Skia persistent GPU related artifacts cache. #6278

Wire up the Skia persistent GPU related artifacts cache. #6278

Uh oh!

Conversation

chinmaygarde commented Sep 18, 2018

Uh oh!

chinmaygarde commented Sep 19, 2018

Uh oh!

Uh oh!

jason-simmons Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

jason-simmons Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jason-simmons Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gubaojian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jason-simmons Sep 20, 2018 •

edited

Loading

chinmaygarde commented Sep 21, 2018 •

edited

Loading

gubaojian left a comment •

edited

Loading