This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use anti-aliasing when drawing text in the performance overlay #7445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The engine dropped the ability to draw non anti-aliased text in https://fuchsia.googlesource.com/third_party/freetype2/+/a10b062df0c8958d69377aa04ea6554a9961a111 Fixes flutter/flutter#26387
jason-simmons
force-pushed
the
bug_26387
branch
from
a933c85 to
c517021
Compare
jason-simmons
changed the title
|
Ahh that explains why the iOS overlay is not antialiased and is still able to be drawn. |
GaryQian
approved these changes
Jan 10, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
This was referenced Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2019
flutter/engine@b7f6bf0...35daf14 git log b7f6bf0..35daf14 --no-merges --oneline 35daf14 Roll src/third_party/skia d2fa7e33798c..c334df71b8f9 (45 commits) (flutter/engine#7448) 6179ac6 fix up analysis for Dart in Engine (flutter/engine#7404) bec12d8 Reland Dart SDK rolls made since 2019/01/08 (flutter/engine#7446) 3f99878 Match the ios number input type behavior to what is said in the docs (flutter/engine#7281) 358a24c Make SetLocales more consistent with other RuntimeController methods (flutter/engine#7447) 0c11836 Use anti-aliasing when drawing text in the performance overlay (flutter/engine#7445) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@b7f6bf0...35daf14 git log b7f6bf0..35daf14 --no-merges --oneline 35daf14 Roll src/third_party/skia d2fa7e33798c..c334df71b8f9 (45 commits) (flutter/engine#7448) 6179ac6 fix up analysis for Dart in Engine (flutter/engine#7404) bec12d8 Reland Dart SDK rolls made since 2019/01/08 (flutter/engine#7446) 3f99878 Match the ios number input type behavior to what is said in the docs (flutter/engine#7281) 358a24c Make SetLocales more consistent with other RuntimeController methods (flutter/engine#7447) 0c11836 Use anti-aliasing when drawing text in the performance overlay (flutter/engine#7445) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine dropped the ability to draw non anti-aliased text in
https://fuchsia.googlesource.com/third_party/freetype2/+/a10b062df0c8958d69377aa04ea6554a9961a111
Fixes flutter/flutter#26387