-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Performance Overlay's Text is Missing in Android #26387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
a: typography
Text rendering, possibly libtxt
c: regression
It was better in the past than it is now
dependency: skia
Skia team may need to help us
engine
flutter/engine repository. See also e: labels.
Comments
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this issue
Jan 10, 2019
The engine dropped the ability to draw non anti-aliased text in https://fuchsia.googlesource.com/third_party/freetype2/+/a10b062df0c8958d69377aa04ea6554a9961a111 Fixes flutter/flutter#26387
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this issue
Jan 10, 2019
The engine dropped the ability to draw non anti-aliased text in https://fuchsia.googlesource.com/third_party/freetype2/+/a10b062df0c8958d69377aa04ea6554a9961a111 Fixes flutter/flutter#26387
jason-simmons
added a commit
to flutter/engine
that referenced
this issue
Jan 10, 2019
The engine dropped the ability to draw non anti-aliased text in https://fuchsia.googlesource.com/third_party/freetype2/+/a10b062df0c8958d69377aa04ea6554a9961a111 Fixes flutter/flutter#26387
liyuqian
added a commit
to liyuqian/engine
that referenced
this issue
Jan 18, 2019
So we can do golden test on PerformanceOverlay to avoid regression like flutter/flutter#26387
liyuqian
added a commit
to liyuqian/flutter
that referenced
this issue
Jan 18, 2019
To avoid regression like flutter#26387 Need flutter/engine#7537 to land first.
liyuqian
added a commit
to liyuqian/engine
that referenced
this issue
Jan 28, 2019
So we can do golden test on PerformanceOverlay to avoid regression like flutter/flutter#26387
liyuqian
added a commit
to flutter/engine
that referenced
this issue
Feb 8, 2019
So we can do golden test on PerformanceOverlay to avoid regression like flutter/flutter#26387
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: typography
Text rendering, possibly libtxt
c: regression
It was better in the past than it is now
dependency: skia
Skia team may need to help us
engine
flutter/engine repository. See also e: labels.
There should be fps and ms/frame statistics texts in performance overlay but they're missing on my Moto G4 (with or without software rendering) and my Linux Android simulator.
Strangely, the text appears on iOS simulator and iOS devices.
The text is drawn in https://github.com/flutter/engine/blob/master/flow/layers/performance_overlay_layer.cc#L22 without any font config. So this might be a Skia regression.
The text was updated successfully, but these errors were encountered: