Change embedded browser setting #5561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helin24
commented
Jun 9, 2021
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| // TODO(helin24): This is to change the embedded browser setting back to true only once for Big Sur users. If we | |||
| // switch to enabling the embedded browser for everyone, then delete this key. | |||
| private static final String changeBigSurToTrueKey = "io.flutter.setBigSurToTrueKey"; | |||
| private static final String changeBigSurToTrueKey = "io.flutter.setBigSurToTrueKey2"; | |||
There was a problem hiding this comment.
Needed a different key since the earlier one will have been set in v57.
stevemessick
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5557
It looks like the previous change was returning
truefor the embedded browser status once, but not saving it. I'm not sure how I missed this in testing last month; it's possible I built an earlier version with this line while testing the change and then accidentally deleted it before submitting. I verified with this current version that the embedded browser status is set to true.