Skip to content

Change embedded browser setting #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Change embedded browser setting #5561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/io/flutter/settings/FlutterSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class FlutterSettings {

// TODO(helin24): This is to change the embedded browser setting back to true only once for Big Sur users. If we
// switch to enabling the embedded browser for everyone, then delete this key.
private static final String changeBigSurToTrueKey = "io.flutter.setBigSurToTrueKey";
private static final String changeBigSurToTrueKey = "io.flutter.setBigSurToTrueKey2";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed a different key since the earlier one will have been set in v57.


/**
* Registry key to suggest all run configurations instead of just one.
Expand Down Expand Up @@ -312,6 +312,7 @@ public boolean isEnableEmbeddedBrowsers() {

// We do not want to set it back to true again in the future (e.g. if a user decides to set to false).
setChangeBigSurToTrue(false);
setEnableEmbeddedBrowsers(true);
return true;
}

Expand Down