Skip to content

Delete firebase_android_embedding_v2_smoke_test #158223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 6, 2024

Delete the Android V2 embedding smoke test now that the V1 embedding has been deleted #143531.

Additionally, this was in bringup for months.

Fixes #158221

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review November 6, 2024 18:01
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2024
@auto-submit auto-submit bot merged commit a987694 into flutter:master Nov 6, 2024
142 checks passed
@jmagman jmagman deleted the firebase_android_embedding_v2_smoke_test branch November 6, 2024 21:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 11, 2024
flutter/flutter@73546b3...c8510f2

2024-11-08 [email protected] Roll Flutter Engine from 44d788f4651b to a08bd5a07c2a (3 revisions) (flutter/flutter#158375)
2024-11-08 [email protected] Add ability to override `NavigationDestination.label` padding for `NavigationBar` (flutter/flutter#158260)
2024-11-08 [email protected] Add flutter/package code generation instructions (flutter/flutter#158326)
2024-11-08 [email protected] Roll Flutter Engine from 8e19915c19fc to 44d788f4651b (3 revisions) (flutter/flutter#158362)
2024-11-08 [email protected] Roll Flutter Engine from bcb281cde579 to 8e19915c19fc (4 revisions) (flutter/flutter#158354)
2024-11-07 [email protected] Make `_SelectableRegionSelectionContainerDelegate` public (flutter/flutter#147080)
2024-11-07 [email protected] Manual roll Flutter Engine from 371c86fb6b49 to bcb281cde579 (flutter/flutter#158346)
2024-11-07 [email protected] Add clarification on review timelines in PR template (flutter/flutter#158345)
2024-11-07 [email protected] Increase Java heap limit to 8GB for plugin integration tests using deferred components (flutter/flutter#158330)
2024-11-07 [email protected] Roll pub packages (flutter/flutter#158337)
2024-11-07 [email protected] Roll Flutter Engine from ac50b20ae5c9 to 371c86fb6b49 (5 revisions) (flutter/flutter#158336)
2024-11-07 [email protected] Fix a breakage caused by the test being unskipped. (flutter/flutter#158335)
2024-11-07 [email protected] Roll Flutter Engine from 8a963cfc134c to ac50b20ae5c9 (1 revision) (flutter/flutter#158308)
2024-11-07 [email protected] `Plugin.isDevDependency` if exclusively in `dev_dependencies` (flutter/flutter#157462)
2024-11-07 [email protected] Add recently imported packages to issue template (flutter/flutter#158324)
2024-11-07 [email protected] Roll Flutter Engine from 076688d95818 to 8a963cfc134c (1 revision) (flutter/flutter#158304)
2024-11-07 [email protected] Roll Flutter Engine from 94dac953a95f to 076688d95818 (2 revisions) (flutter/flutter#158303)
2024-11-07 [email protected] Make leak tracking bots blocking. (flutter/flutter#157866)
2024-11-07 [email protected] Roll Flutter Engine from b36ca3319825 to 94dac953a95f (1 revision) (flutter/flutter#158297)
2024-11-06 [email protected] Roll Flutter Engine from 58ac1dadd69d to b36ca3319825 (9 revisions) (flutter/flutter#158295)
2024-11-06 [email protected] Added cusor control properties to CupertinoSearchTextField and tests (flutter/flutter#158240)
2024-11-06 [email protected] Fix flakiness in hot_reload_test.dart (flutter/flutter#158271)
2024-11-06 [email protected] Fix use of deprecated `buildDir` in Android templates/tests/examples (flutter/flutter#157560)
2024-11-06 [email protected] Roll Flutter Engine from f03f11300a9d to 58ac1dadd69d (5 revisions) (flutter/flutter#158283)
2024-11-06 [email protected] Roll pub packages (flutter/flutter#158281)
2024-11-06 [email protected] Delete firebase_android_embedding_v2_smoke_test (flutter/flutter#158223)
2024-11-06 [email protected] [web] fix --ab option for web benchmarks (flutter/flutter#154574)
2024-11-06 [email protected] excluding website-cms from critical pr triage (flutter/flutter#158220)
2024-11-06 [email protected] Add test for `image.frame_builder.0.dart` (flutter/flutter#158247)
2024-11-06 [email protected] Roll Packages from 7219431 to bb5a258 (6 revisions) (flutter/flutter#158267)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
`firebase_release_smoke_test` was [marked
flaky](#147338) due to a firebase
outage in April.
`firebase_android_embedding_v2_smoke_test` was deleted with
#158223.
`firebase_abstract_method_smoke_test` was deleted with #159145

Closes #147335.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete firebase_android_embedding_v2_smoke_test test
2 participants