Skip to content

[pointer_interceptor] Add iOS implementation and platform interface #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 57 commits into from
Closed

[pointer_interceptor] Add iOS implementation and platform interface #5233

wants to merge 57 commits into from

Conversation

LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Oct 25, 2023 •
edited
Loading

Addresses flutter/flutter#30143 by adding an iOS implementation

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

cyanglaz
cyanglaz reviewed Oct 25, 2023
View reviewed changes
packages/pointer_interceptor/pointer_interceptor_ios/ios/Classes/DummyPlatformViewFactory.swift Outdated
import Flutter
import UIKit

public class DummyPlatformViewFactory: NSObject, FlutterPlatformViewFactory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in the example/ios/Runner

@LouiseHsu LouiseHsu changed the title initial working commit [pointer_interceptor] Add iOS implementation and platform interface Oct 30, 2023
@LouiseHsu LouiseHsu marked this pull request as ready for review October 30, 2023 23:11
@LouiseHsu LouiseHsu requested a review from ditman as a code owner October 30, 2023 23:11
@LouiseHsu LouiseHsu mentioned this pull request Nov 1, 2023
Merged
11 tasks
This was referenced Nov 28, 2023
Merged
Closed
auto-submit bot pushed a commit that referenced this pull request Nov 30, 2023
@LouiseHsu
[pointer_interceptor] Add platform interface (#5499)
98b85da 
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of #5233
@auto-submit auto-submit bot mentioned this pull request Nov 30, 2023
Merged
11 tasks
auto-submit bot added a commit that referenced this pull request Nov 30, 2023
@auto-submit
Reverts "[pointer_interceptor] Add platform interface" (#5524)
bc72d15 
Reverts #5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of #5233
@stuartmorgan-g stuartmorgan-g mentioned this pull request Nov 30, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Nov 30, 2023
@stuartmorgan-g
[pointer_interceptor] Re-land: Add platform interface (#5525)
293b071 
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 1 of #5233

This reverts commit bc72d15 and then fixes the topic format
auto-submit bot pushed a commit that referenced this pull request Dec 6, 2023
@LouiseHsu
[pointer_interceptor] Add ios implementation and move web implementat…
96310cc 
…ion to federated structure (#5500)

Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of #5233
@auto-submit auto-submit bot mentioned this pull request Dec 6, 2023
Merged
11 tasks
auto-submit bot added a commit that referenced this pull request Dec 6, 2023
@auto-submit
Reverts "[pointer_interceptor] Add ios implementation and move web im…
c9033ca 
…plementation to federated structure" (#5591)

Reverts #5500
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of #5233
@LouiseHsu LouiseHsu mentioned this pull request Dec 6, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Dec 7, 2023
@LouiseHsu
Pointer interceptor implementations (#5594)
2911b87 
This is essentially the same PR as #5500, with pubspec updates
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 2 of #5233
@LouiseHsu LouiseHsu mentioned this pull request Dec 11, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Dec 11, 2023
@LouiseHsu
[pointer_interceptor] Fully publish pointer_interceptor package (#5640)
8163731 
Addresses flutter/flutter#30143 by adding an iOS implementation, and flutter/flutter#138217 by fixing README links

This PR is Part 3/3 of #5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@LouiseHsu @HugoOlthof
[pointer_interceptor] Move pointer_interceptor to sub folder (flutter…
434da58 
…#5291)

Prep PR for flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@LouiseHsu @HugoOlthof
[pointer_interceptor] Add platform interface (flutter#5499)
fcf4e02 
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@auto-submit @HugoOlthof
Reverts "[pointer_interceptor] Add platform interface" (flutter#5524)
00ad845 
Reverts flutter#5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@stuartmorgan-g @HugoOlthof
[pointer_interceptor] Re-land: Add platform interface (flutter#5525)
2390966 
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 1 of flutter#5233

This reverts commit bc72d15 and then fixes the topic format
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@LouiseHsu @HugoOlthof
[pointer_interceptor] Add ios implementation and move web implementat…
ce37977 
…ion to federated structure (flutter#5500)

Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@auto-submit @HugoOlthof
Reverts "[pointer_interceptor] Add ios implementation and move web im…
3f6b668 
…plementation to federated structure" (flutter#5591)

Reverts flutter#5500
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@LouiseHsu @HugoOlthof
Pointer interceptor implementations (flutter#5594)
b60f508 
This is essentially the same PR as flutter#5500, with pubspec updates
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 2 of flutter#5233
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@LouiseHsu @HugoOlthof
[pointer_interceptor] Fully publish pointer_interceptor package (flut…
e02e8bb 
…ter#5640)

Addresses flutter/flutter#30143 by adding an iOS implementation, and flutter/flutter#138217 by fixing README links

This PR is Part 3/3 of flutter#5233
@LouiseHsu LouiseHsu closed this Dec 13, 2023
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@LouiseHsu @arc-yong
[pointer_interceptor] Add platform interface (flutter#5499)
9c7e349 
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@auto-submit @arc-yong
Reverts "[pointer_interceptor] Add platform interface" (flutter#5524)
f811acf 
Reverts flutter#5499
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 1 of flutter#5233
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan-g @arc-yong
[pointer_interceptor] Re-land: Add platform interface (flutter#5525)
c22eb19 
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 1 of flutter#5233

This reverts commit bc72d15 and then fixes the topic format
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@LouiseHsu @arc-yong
[pointer_interceptor] Add ios implementation and move web implementat…
6e890bf 
…ion to federated structure (flutter#5500)

Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of flutter#5233
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@auto-submit @arc-yong
Reverts "[pointer_interceptor] Add ios implementation and move web im…
fb6eccb 
…plementation to federated structure" (flutter#5591)

Reverts flutter#5500
Initiated by: stuartmorgan
This change reverts the following previous change:
Original Description:
Addresses flutter/flutter#30143 by adding an iOS implementation 

This PR is Part 2 of flutter#5233
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@LouiseHsu @arc-yong
Pointer interceptor implementations (flutter#5594)
815263d 
This is essentially the same PR as flutter#5500, with pubspec updates
Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 2 of flutter#5233
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@LouiseHsu @arc-yong
[pointer_interceptor] Fully publish pointer_interceptor package (flut…
4021c84 
…ter#5640)

Addresses flutter/flutter#30143 by adding an iOS implementation, and flutter/flutter#138217 by fixing README links

This PR is Part 3/3 of flutter#5233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g requested changes

@cyanglaz cyanglaz cyanglaz left review comments

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
p: pointer_interceptor platform-ios platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LouiseHsu @stuartmorgan-g @cyanglaz