[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

LouiseHsu · 2023-11-28T08:28:23Z

Addresses flutter/flutter#30143 by adding an iOS implementation

This PR is Part 2 of #5233

Pre-launch Checklist

packages/pointer_interceptor/pointer_interceptor_web/example/flutter_01.log

packages/pointer_interceptor/pointer_interceptor_web/example/flutter_02.log

packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml

stuartmorgan-g · 2023-11-29T21:14:28Z

packages/pointer_interceptor/pointer_interceptor_web/example/integration_test/widget_test.dart

A trick we came up with while federating the other plugins that preserves git history better (allowing these to be treated as moves instead of copies) is to have this PR add a publish_to: none to pointer_interceptor/pointer_interceptor with a comment saying it's temporarily not being published while federation is in progress, then include deleting the web files from that package in this PR. Then the app-facing PR would remove that again as part of the changes to depend on this package.

How do the ci tests pass for pointerinterceptor/pointerinterceptor in that case? or do I just gut the app facing package completely?

Oh right, sorry. It's been a while since I did this last.

Looking back at my old PRs, what you would do is actually make all of the app-facing changes related to web in the same PR, and add path-based dependencies on the web package. Then tests will pass, and since it's not published it won't fail on having path-based deps.

If it's easier, you could include the iOS changes in the PR so you don't have to untangle them. If you do that, it would basically be what's left of the combo PR but with the temporary pubspec changes like the ones I linked to.

So making sure I understand you correctly: For this PR, I change the path dependencies in pointer_interceptor/pointer_interceptor and add publish_to: none, and also add any web/ios changes from that same folder?
and then for the next PR, it would just revert the pubspec changes + what ever is left?

Yes, exactly. And the "whatever is left" part will probably be very minimal.

Sorry, if I'd remembered how I'd done this when moving existing implementations before I would have described the PR steps very differently; it's really more like 2.1 PRs (one for the platform interface, one for the rest with small temp hacks in the app-facing package, and then final cleanup to make the app-facing publishable again) than 3 in this case. What I told you initially about how to slice the PR into layers is the process for a more typical PR that's just adding something across the entire set of sub-packages.

stuartmorgan-g · 2023-12-06T20:08:13Z

packages/pointer_interceptor/pointer_interceptor_ios/pubspec.yaml

+version: 0.10.0
+
+environment:
+  sdk: '>=3.1.0 <=4.0.0'


I missed the <= here in review; it needs to be < since 4 would indicate breaking changes, so we don't know if it will work with 4. This is causing publish to fail, so I need to revert the PR.

stuartmorgan-g · 2023-12-06T20:08:25Z

packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml

+version: 0.10.0
+
+environment:
+  sdk: '>=3.1.0 <=4.0.0'


…lementation to federated structure (#5500)" This reverts commit 96310cc.

…plementation to federated structure" (#5591) Reverts #5500 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of #5233

stuartmorgan-g · 2023-12-06T20:12:02Z

If you make a new PR with one commit that reverts f47b3b6 without changes and then a second commit that fixes the two constraints, I can review it ASAP.

…lementation to federated structure (flutter/packages#5500)

flutter/packages@ca16173...15584a3 2023-12-07 [email protected] [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 [email protected] Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 [email protected] [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 [email protected] [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 [email protected] [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 [email protected] [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 [email protected] Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 [email protected] [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 [email protected] [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 [email protected] Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 [email protected] [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 [email protected] [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is essentially the same PR as #5500, with pubspec updates Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of #5233

…ion to federated structure (flutter#5500) Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

…plementation to federated structure" (flutter#5591) Reverts flutter#5500 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

This is essentially the same PR as flutter#5500, with pubspec updates Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

…ion to federated structure (flutter#5500) Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

…plementation to federated structure" (flutter#5591) Reverts flutter#5500 Initiated by: stuartmorgan This change reverts the following previous change: Original Description: Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

This is essentially the same PR as flutter#5500, with pubspec updates Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of flutter#5233

LouiseHsu requested a review from ditman as a code owner November 28, 2023 08:28

LouiseHsu requested a review from stuartmorgan-g November 28, 2023 08:28

github-actions bot added p: pointer_interceptor platform-ios platform-web labels Nov 28, 2023

ditman reviewed Nov 29, 2023

View reviewed changes

stuartmorgan-g reviewed Nov 29, 2023

View reviewed changes

LouiseHsu added 3 commits November 30, 2023 11:09

pointer interceptor platform implementations

ff82bc5

pubspec yaml edits

c9f7f71

remove publish to

20d7441

LouiseHsu requested review from reidbaker, camsim99, bparrishMines, Hixie, tarrinneal and domesticmouse as code owners November 30, 2023 19:25

github-actions bot added p: pigeon p: flutter_markdown p: flutter_image p: rfw Remote Flutter Widgets p: camera p: google_maps_flutter p: google_sign_in platform-android p: webview_flutter labels Nov 30, 2023

LouiseHsu removed request for domesticmouse, Hixie, reidbaker, bparrishMines and camsim99 November 30, 2023 19:30

LouiseHsu added 6 commits December 4, 2023 13:33

pr updates

10acb61

fix tests

ba4bc21

update pubspec

477c30f

fix web tests

2b97d04

actually fix tests

30d68ff

pubspec and formatting.............

dae7b4d

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023

auto-submit bot merged commit 96310cc into flutter:main Dec 6, 2023

stuartmorgan-g reviewed Dec 6, 2023

View reviewed changes

stuartmorgan-g added the revert Label used to revert changes in a closed and merged pull request. label Dec 6, 2023

auto-submit bot mentioned this pull request Dec 6, 2023

Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" #5591

Merged

11 tasks

auto-submit bot pushed a commit that referenced this pull request Dec 6, 2023

Revert "[pointer_interceptor] Add ios implementation and move web imp…

f47b3b6

…lementation to federated structure (#5500)" This reverts commit 96310cc.

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Dec 6, 2023

LouiseHsu mentioned this pull request Dec 6, 2023

Pointer interceptor implementations #5594

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request Dec 7, 2023

Roll Packages from ca16173e67e4 to 15584a394d36 (13 revisions) flutter/flutter#139736

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 7, 2023

96310cc [pointer_interceptor] Add ios implementation and move web imp…

fb82f0f

…lementation to federated structure (flutter/packages#5500)

auto-submit bot pushed a commit that referenced this pull request Dec 7, 2023

Pointer interceptor implementations (#5594)

2911b87

This is essentially the same PR as #5500, with pubspec updates Addresses flutter/flutter#30143 by adding an iOS implementation This PR is Part 2 of #5233

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

Uh oh!

LouiseHsu commented Nov 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Nov 29, 2023

Uh oh!

LouiseHsu Nov 29, 2023 •

edited

Loading

Uh oh!

stuartmorgan-g Nov 29, 2023 •

edited

Loading

Uh oh!

stuartmorgan-g Nov 29, 2023

Uh oh!

LouiseHsu Nov 29, 2023

Uh oh!

stuartmorgan-g Nov 30, 2023 •

edited

Loading

Uh oh!

stuartmorgan-g Dec 6, 2023

Uh oh!

stuartmorgan-g Dec 6, 2023

Uh oh!

stuartmorgan-g commented Dec 6, 2023

Uh oh!

Uh oh!

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

[pointer_interceptor] Add ios implementation and move web implementation to federated structure #5500

Uh oh!

Conversation

LouiseHsu commented Nov 28, 2023

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

LouiseHsu Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

LouiseHsu Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Dec 6, 2023

Uh oh!

Uh oh!

LouiseHsu Nov 29, 2023 •

edited

Loading

stuartmorgan-g Nov 29, 2023 •

edited

Loading

stuartmorgan-g Nov 30, 2023 •

edited

Loading