[script] use dart:io support for forwarding stdout/stderr #5410
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5410, due to - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
test-exempt: code refactor with no semantic change |
flutter/packages@0cd2378...07b4b29 2023-11-16 [email protected] [script] use dart:io support for forwarding stdout/stderr (flutter/packages#5410) 2023-11-15 [email protected] Manual roll Flutter (stable) from d211f42 to db7ef5b (1539 revisions) (flutter/packages#5409) 2023-11-15 [email protected] [in_app_purchase] add storefront in skpaymentqueuewrapper (flutter/packages#5348) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Applies the same change as flutter#5410 to the Pigeon tooling, avoiding the need to manually wire up output forwarding. Also adjusts some callsites in the tooling that were forwarding all output normally but then also logging all output on failure to only log all output on failure.
Applies the same change as #5410 to the Pigeon tooling, avoiding the need to manually wire up output forwarding. Also adjusts a call site in the tooling that was forwarding all output normally but then also logging all output on failure to only log all output on failure.
No description provided.