Skip to content

[script] use dart:io support for forwarding stdout/stderr #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[script] use dart:io support for forwarding stdout/stderr #5410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dffcf59
[script] use dart:io support for forwarding stdout/stderr
kevmoo Nov 15, 2023
d71200c
Merge branch 'main' into tool_tweak
kevmoo Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions script/tool/lib/src/common/process_runner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,9 @@ class ProcessRunner {
print(
'Running command: "$executable ${args.join(' ')}" in ${workingDir?.path ?? io.Directory.current.path}');
final io.Process process = await io.Process.start(executable, args,
workingDirectory: workingDir?.path, environment: environment);
await Future.wait(<Future<dynamic>>[
io.stdout.addStream(process.stdout),
io.stderr.addStream(process.stderr),
]);
workingDirectory: workingDir?.path,
environment: environment,
mode: io.ProcessStartMode.inheritStdio);
if (exitOnError && await process.exitCode != 0) {
final String error =
_getErrorString(executable, args, workingDir: workingDir);
Expand Down