[vector_graphics_compiler] fix-null-exception #8006
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist is complete and reflects the state of the PR as posted please feel free to mark it as ready for review. |
EArminjon
changed the title
EArminjon
force-pushed
the
fix-null-exception
branch
from
31c3b93 to
feaf9a4
Compare
EArminjon
force-pushed
the
fix-null-exception
branch
from
feaf9a4 to
8072e4c
Compare
|
Sorry for delay. PR updated. |
|
@EArminjon can you resolve the merge conflicts? A few versions got published in the last week. |
EArminjon
force-pushed
the
fix-null-exception
branch
from
8072e4c to
63d6a30
Compare
|
@jonahwilliams done :) |
stuartmorgan-g
added
the
autosubmit
flutter/packages@72356fd...26e123a 2024-11-13 [email protected] [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 [email protected] [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 [email protected] [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 [email protected] [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 [email protected] [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 [email protected] [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 [email protected] [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 [email protected] [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 [email protected] [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 [email protected] Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 [email protected] Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 [email protected] [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 [email protected] [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 [email protected] [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 [email protected] Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 [email protected] [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 [email protected] Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 [email protected] [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 [email protected] [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The following SVG throw an exception (when using flutter_svg) : https://sweden.a.bigcontent.io/v1/static/10000199.
This SVG contain an empty tag : which lead to the issue.
This PR check if path is null to avoid the issue.
PR from dnfield/vector_graphics#254
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.