[ios_platform_images] Switch to loadImage
#8216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the deprecated `loadBuffer` override with the newer `loadImage`, removing the need to use the deprecated `BecoderBufferCallback` class. Fixes flutter/flutter#143880
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
|
From triage: This is waiting for iOS review, but didn't have the label |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2025
flutter/packages@3d3ab7b...258f6dc 2025-01-24 [email protected] [shared_preferences] Add shared preferences devtool (flutter/packages#8494) 2025-01-24 [email protected] [shared_preferences] update List<String> encode/decode (flutter/packages#8335) 2025-01-24 [email protected] Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter/packages#8498) 2025-01-24 [email protected] [ios_platform_images] Switch to `loadImage` (flutter/packages#8216) 2025-01-24 [email protected] [camera] Remove OCMock from CameraExposureTests and CameraFocusTests (flutter/packages#8351) 2025-01-24 [email protected] [shared_preferences] Tool for migrating from legacy shared_preferences to shared_preferences_async (flutter/packages#8229) 2025-01-23 [email protected] Revert "[shared_preferences] Add shared preferences devtool" (flutter/packages#8493) 2025-01-23 [email protected] [go_router] Fix return type of current state getter to be non-nullable (flutter/packages#8173) 2025-01-23 [email protected] Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter/packages#8491) 2025-01-23 [email protected] [pigeon] fixes event channel dart instance name usage and adds test (flutter/packages#8483) 2025-01-23 [email protected] [go _route] fragment parameter added (flutter/packages#8232) 2025-01-23 [email protected] [in_app_purchase] Update in_app_purchase_android version in in_app_purchase (flutter/packages#8463) 2025-01-23 [email protected] [image_picker] Reference alternate macOS implementations (flutter/packages#8487) 2025-01-23 [email protected] [rfw] Activate leak testing (flutter/packages#8370) 2025-01-23 [email protected] [video_player] Activate leak testing (flutter/packages#8379) 2025-01-23 [email protected] Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter/packages#8482) 2025-01-23 [email protected] [camera] Add API support query for image streaming (app-facing) (flutter/packages#8422) 2025-01-23 [email protected] Manual roll Flutter from b9e86a5 to eb6af3d (13 revisions) (flutter/packages#8473) 2025-01-23 [email protected] [shared_preferences] Add shared preferences devtool (flutter/packages#8322) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated
loadBufferoverride with the newerloadImage, removing the need to use the deprecatedDecoderBufferCallbackclass.This is largely a no-op because the difference between
DecoderBufferCallbackandImageDecoderCallbackis entirely in optional parameters the package doesn't use.Fixes flutter/flutter#143880
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).