[shared_preferences] Add shared preferences devtool

[adsonpleal]

This PR adds the shared_preferences_tool package. This package uses the devtools_extension tooling to create a tool for shared preferences. The idea of this PR came from @kenzieschmoll on this issue. Initially I've published this tool as a separate package, but this PR aims to bring the functionality to the main shared_preferences package. Once this PR gets merged I'll archive the shared_preferences_tools package.

shared_preferences_tools.mp4

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[adsonpleal]

@kenzieschmoll and @stuartmorgan reopening the PR for the reverted changes.

@kenzieschmoll now I'm getting an error on Linux analyze stable step:

Also, I don't know why the changes are different, checked every file, but this PR seems to have +7,851 additions and the old one had +5,156. I guess github is counting it wrong 🤷 .

[adsonpleal]

Never mind the additions issue! I actually found the offending file. [shared_preferences_tool_eval_test.mocks.dart](https://github.com/flutter/packages/pull/8322/files#diff-569dab15b9971e9d7447872f2ff00405e9c4374ae84a0e3b47a368c085e8c778) is way bigger, since EvalOnDartLibrary and VmService APIs have changed!

I'll remove mockito for this file, 3k+ changes just for the mocks is not reasonable.

[adsonpleal]

@kenzieschmoll about the SDK constraint required by the CI, should we reduce the min version on devtools_entensions(by releasing a new version)? Or should I just downgrade it to 0.2.2? The 0.2.2 version was working fine on the CI.

EDIT:

Unfortunately I can't downgrade it either:

[kenzieschmoll]

I think if you upgrade the devtools_app_shared dependency to ^0.3.0 in shared_preferences_tool that should fix your version solving issue.

[adsonpleal]

I think if you upgrade the devtools_app_shared dependency to ^0.3.0 in shared_preferences_tool that should fix your version solving issue.

That is the issue, it is already on ^0.3.0, as you can see here. But the CI is failing failing with this error:

============================================================
|| Running for packages/shared_preferences/shared_preferences_tool [@3:06]
============================================================

Running command: "flutter pub get" in /b/s/w/ir/x/w/packages/packages/shared_preferences/shared_preferences_tool
Resolving dependencies...
The current Flutter SDK version is 3.27.0.

Because shared_preferences_tool depends on devtools_extensions >=0.3.0 which requires Flutter SDK version >=3.27.1, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Try using the Flutter SDK version: 3.27.1. 
Failed to update packages.

[packages/shared_preferences/shared_preferences_tool completed in 0m 2s]

The Linux analyze stable is running flutter 3.27.0 🤔 .

@stuartmorgan do you know if the Linux analyze stable will (or already is) be updated to 3.27.1? This should fix the problem.

[kenzieschmoll]

@stuartmorgan do you know if the Linux analyze stable will (or already is) be updated to 3.27.1? This should fix the problem.

Agreed this should be our target solution. If this is not possible, I can downgrade the min version to 3.27.0 and do a patch release of devtools_app_shared and devtools_extensions. Will wait for @stuartmorgan to comment.

[tarrinneal]

Because shared_preferences_tool depends on devtools_extensions >=0.3.0 which requires Flutter SDK version >=3.27.1, version solving failed.

seems like you need to resolve this to fix the failing tests

[kenzieschmoll]

@adsonpleal can you try merging with the main branch again to see if that resolves the pub solve errors we are seeing?

[adsonpleal]

Hey @kenzieschmoll I think it worked for master and stable, but it is failing due timeout. I don't have permission to re-run a check.

But it is still failing for legacy, and I think it will aways fail. This is the error:

The current Dart SDK version is 3.5.4.

Because shared_preferences_tool depends on devtools_extensions >=0.3.0-dev.0 which requires SDK version >=3.6.0-149.3.beta <4.0.0, version solving failed.

I wonder if there is a way to disable the legacy checks for shared_preferences_tool? It will never run on legacy SDKs, since it is a self-contained build. It is not intended to be used as a dependency.

[stuartmorgan-g]

I wonder if there is a way to disable the legacy checks for shared_preferences_tool?

Legacy checks run on the versions a package claims to support; this PR claims that the package supports Dart 3.4.0+

If that is incorrect, the solution is to fix the package's support declaration, not to work around the tests.

[adsonpleal]

I wonder if there is a way to disable the legacy checks for shared_preferences_tool?

Legacy checks run on the versions a package claims to support; this PR claims that the package supports Dart 3.4.0+

If that is incorrect, the solution is to fix the package's support declaration, not to work around the tests.

Amazing! This is it, it should match devtools_extensions's constraints! Thanks @stuartmorgan, I'll push a fix for it.

[adsonpleal]

@kenzieschmoll Now the checks are green. We still have two red ones, but I guess we just need to re-run them.

[kenzieschmoll]

Everything is green except the tree. I have added the "waiting for tree to go green" label so this should automatically submit once the tree is green

[adsonpleal]

@kenzieschmoll Now everything is green, so we just need @tarrinneal's review, right?

[tarrinneal]

Thanks for seeing this through again :)

[kenzieschmoll]

Looks like the release action failed for this PR: https://github.com/flutter/packages/actions/runs/12919330644/job/36032316281

Mac_arm64 macos_platform_tests stable - packages: completed (failure)

I'm trying a re-run now to ensure this wasn't a flake.

[stuartmorgan-g]

It looks like it was video_player flake. This PR triggers tests in every package due to the script/configs change.

[adsonpleal]

@stuartmorgan and @kenzieschmoll the run failed again. It seems that it is failing due to the flutter version.

The workflow is set to run on flutter 3.27.0.

Resolving dependencies...
The current Flutter SDK version is 3.27.0.

Because shared_preferences_tool depends on devtools_extensions >=0.3.0 which requires Flutter SDK version >=3.27.1, version solving failed.

[stuartmorgan-g]

Ah, this generally doesn't happen because we don't usually have tight version constraints on the release flow.

The easiest thing to do here would be to revert this, and the re-land it with an added change to bump this line.

[adsonpleal]

Got it. So, should I create the revert PR or you'll do it? @stuartmorgan

Edit: I don't think I have permissions to create a revert PR.

[stuartmorgan-g]

I've created a revert.