-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camera_android_camerax] Remove logic used to previously correct preview rotation #8256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Works for me as of today on the following devices I tested (and their Impeller logs):
|
…rrect preview rotation (flutter/packages#8256)
…rrect preview rotation (flutter/packages#8256)
…rrect preview rotation (flutter/packages#8256)
flutter/packages@6554751...3c3bc68 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 2 directories with 1 update (flutter/packages#8412) 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8411) 2025-01-11 [email protected] Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#8413) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#8410) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8357) 2025-01-10 [email protected] Fix dependabot test-dependencies group io.mockk regex (flutter/packages#8406) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306) 2025-01-10 [email protected] [url_launcher_windows] Correct logging url (flutter/packages#8107) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#8358) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the androidx group across 3 directories with 1 update (flutter/packages#8329) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20241224 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8372) 2025-01-10 [email protected] [url_launcher][web] Better support for semantics in the Link widget (flutter/packages#6711) 2025-01-10 [email protected] [camera]: Activate leak testing for sub packages (flutter/packages#8353) 2025-01-09 [email protected] [camera_android_camerax] Remove logic used to previously correct preview rotation (flutter/packages#8256) 2025-01-09 [email protected] [go_router] Rephrases readme to better describe the current status (flutter/packages#8403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#161515) flutter/packages@6554751...3c3bc68 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 2 directories with 1 update (flutter/packages#8412) 2025-01-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8411) 2025-01-11 [email protected] Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20250107 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#8413) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20241224 to 20250107 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#8410) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8357) 2025-01-10 [email protected] Fix dependabot test-dependencies group io.mockk regex (flutter/packages#8406) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#7306) 2025-01-10 [email protected] [url_launcher_windows] Correct logging url (flutter/packages#8107) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#8358) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the androidx group across 3 directories with 1 update (flutter/packages#8329) 2025-01-10 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20241224 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#8372) 2025-01-10 [email protected] [url_launcher][web] Better support for semantics in the Link widget (flutter/packages#6711) 2025-01-10 [email protected] [camera]: Activate leak testing for sub packages (flutter/packages#8353) 2025-01-09 [email protected] [camera_android_camerax] Remove logic used to previously correct preview rotation (flutter/packages#8256) 2025-01-09 [email protected] [go_router] Rephrases readme to better describe the current status (flutter/packages#8403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I fear this broke the live camera preview on some Android devices (where the preview is now distorted and rotated by 90°). For example see: khoren93/flutter_zxing#169 |
Preview rotation correction logic was added back in |
Works like a charm. Thanks |
Removes correction logic used to the correct the rotation of the camera preview, since it appears* to not be needed anymore.
Partially addresses flutter/flutter#154241.
*This is not true for emulators, but if we are ok landing this issue for real devices, I'll file an issue for emulators and follow up there. jonahwilliams@ mentioned there is known different behavior in emulators with Impeller, so this fact is not totally a surprise.
My basis for landing this is:
packages/packages/camera/camera/lib/src/camera_preview.dart
Lines 46 to 72 in 8ca81bd
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).