Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker]Add argument maxDuration to video record #1518

Closed
wants to merge 2 commits into from

Conversation

cyanglaz
Copy link
Contributor

Description

Can pass a double of seconds to maxDuration to limit the duration of the video record.
This is a fork of #674. Due to the inactivity of the original author, I am taking over his change and going to work on it from now on.

Can pass a double of seconds to maxDuration to limit the duration of the video record

Implement Pull request feedback

Remove extra white space and document ImagePicker.pickVideo method channel

Set a record ma duration from a Duration
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@cyanglaz cyanglaz closed this Apr 19, 2019
@cyanglaz cyanglaz deleted the image_picker_maxduration branch April 19, 2019 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants