[image_picker]Add argument maxDuration to video record #674

vagrantrobbie · 2018-07-18T23:26:05Z

Can pass a double of seconds to maxDuration to limit the duration of the video record

googlebot · 2018-07-18T23:26:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

vagrantrobbie · 2018-07-18T23:28:04Z

I signed it!

googlebot · 2018-07-18T23:28:06Z

CLAs look good, thanks!

goderbauer · 2018-07-30T19:40:14Z

packages/image_picker/lib/image_picker.dart

  }) async {
    assert(source != null);

    final String path = await _channel.invokeMethod(
      'pickVideo',
      <String, dynamic>{
        'source': source.index,
+        'maxDuration':maxDuration


nit: space after :

goderbauer · 2018-07-30T19:40:41Z

packages/image_picker/ios/Classes/ImagePickerPlugin.m

@@ -73,16 +73,25 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
        break;
    }
  } else if ([@"pickVideo" isEqualToString:call.method]) {
+


nit: unnecessary extra blank line.

goderbauer · 2018-07-30T19:40:46Z

packages/image_picker/ios/Classes/ImagePickerPlugin.m

    _imagePickerController.modalPresentationStyle = UIModalPresentationCurrentContext;
    _imagePickerController.delegate = self;
    _imagePickerController.mediaTypes = @[
      (NSString *)kUTTypeMovie, (NSString *)kUTTypeAVIMovie, (NSString *)kUTTypeVideo,
      (NSString *)kUTTypeMPEG4
    ];
    _imagePickerController.videoQuality = UIImagePickerControllerQualityTypeHigh;
+


nit: unnecessary extra blank line.

goderbauer · 2018-07-30T19:41:45Z

packages/image_picker/lib/image_picker.dart

@@ -58,13 +58,15 @@ class ImagePicker {

  static Future<File> pickVideo({
    @required ImageSource source,
+    double maxDuration


Can you add a doc comment to pickVideo that documents this function (similarly to how it is done for pickImage) and also describe the new parameter maxDuration in there?

goderbauer · 2018-07-30T19:42:22Z

packages/image_picker/lib/image_picker.dart

@@ -58,13 +58,15 @@ class ImagePicker {

  static Future<File> pickVideo({
    @required ImageSource source,
+    double maxDuration


Also: would it be better if maxDuration is actually of type Duration? Currently it is unclear what the unit for durations is. Seconds? Minutes? Hours?

I will add a note that the maxDuration is in Seconds.

goderbauer · 2018-07-30T19:42:54Z

...s/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

@@ -237,6 +237,14 @@ private void launchTakeVideoWithCameraIntent() {
    intent.putExtra(MediaStore.EXTRA_OUTPUT, videoUri);
    grantUriPermissions(intent, videoUri);

+    // Set a maximum duration for the video record


nit: the comment is not really providing any value. Maybe remove?

goderbauer · 2018-07-30T19:43:06Z

packages/image_picker/ios/Classes/ImagePickerPlugin.m


    _result = result;
    _arguments = call.arguments;
+
+    // Set a maximum duration for the video record


Same as above.

goderbauer · 2018-07-30T19:44:00Z

You'll also have to address the formatting issues uncovered by our CI: https://cirrus-ci.com/task/5089761320501248

Remove extra white space and document ImagePicker.pickVideo method channel

packages/image_picker/lib/image_picker.dart

vagrantrobbie · 2018-09-30T23:51:49Z

Now uses Duration

Hixie · 2018-10-25T16:19:30Z

@vagrantrobbie looks like something bad happened with the dependencies here, not sure why. Can you try updating to tip of tree and resubmitting? Maybe try running the tests locally, see if they work there.

cyanglaz · 2019-04-19T23:15:51Z

@vagrantrobbie Could you try rebase and see if the CI issue is resolved?

cyanglaz · 2019-07-08T17:32:22Z

@vagrantrobbie I'm going to relentlessly close this PR since it has been inactive for a while. I encourage you to reopen it when you are ready to work on it.

Add argument maxDuration to video record

b6e5379

Can pass a double of seconds to maxDuration to limit the duration of the video record

googlebot added the cla: no label Jul 18, 2018

googlebot added cla: yes and removed cla: no labels Jul 18, 2018

goderbauer suggested changes Jul 30, 2018

View reviewed changes

Implement Pull request feedback

62cc92a

Remove extra white space and document ImagePicker.pickVideo method channel

goderbauer reviewed Jul 30, 2018

View reviewed changes

packages/image_picker/lib/image_picker.dart Show resolved Hide resolved

packages/image_picker/lib/image_picker.dart Show resolved Hide resolved

Set a record ma duration from a Duration

3c3fea2

vagrantrobbie closed this Oct 1, 2018

vagrantrobbie reopened this Oct 1, 2018

Hixie added the needs love label Oct 25, 2018

cyanglaz changed the title ~~Add argument maxDuration to video record~~ [image_picker]Add argument maxDuration to video record Feb 22, 2019

cyanglaz added the feature label Feb 22, 2019

cyanglaz self-assigned this Apr 19, 2019

cyanglaz mentioned this pull request Apr 19, 2019

[image_picker]Add argument maxDuration to video record #1518

Closed

cyanglaz closed this Jul 8, 2019

TimWhiting mentioned this pull request Mar 8, 2020

[path_provider] path provider linux implementation in dart #2589

Merged

12 tasks

[image_picker]Add argument maxDuration to video record #674

[image_picker]Add argument maxDuration to video record #674

Uh oh!

Conversation

vagrantrobbie commented Jul 18, 2018

Uh oh!

googlebot commented Jul 18, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

vagrantrobbie commented Jul 18, 2018

Uh oh!

googlebot commented Jul 18, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Jul 30, 2018

Uh oh!

Uh oh!

Uh oh!

vagrantrobbie commented Sep 30, 2018

Uh oh!

Hixie commented Oct 25, 2018

Uh oh!

cyanglaz commented Apr 19, 2019

Uh oh!

cyanglaz commented Jul 8, 2019

Uh oh!

Uh oh!