Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Remove exoplayer workaround from everything but video_player #3980

Merged
merged 2 commits into from
May 27, 2021
Merged

Remove exoplayer workaround from everything but video_player #3980

merged 2 commits into from
May 27, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented May 26, 2021 •
edited
Loading

Now that video_player includes this workaround at the plugin level, it's no longer necessary in the examples that use it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 26, 2021
@stuartmorgan-g stuartmorgan-g marked this pull request as draft May 26, 2021 20:49
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review May 26, 2021 22:00
@stuartmorgan-g stuartmorgan-g requested review from jmagman and blasten May 26, 2021 22:01
jmagman
jmagman approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with question about image_picker/example

jmagman
jmagman reviewed May 26, 2021
View reviewed changes
@jmagman jmagman mentioned this pull request May 27, 2021
Merged
11 tasks
@stuartmorgan-g stuartmorgan-g merged commit f7ee663 into flutter:master May 27, 2021
@stuartmorgan-g stuartmorgan-g deleted the exoplayer-workaround-cleanup branch May 27, 2021 14:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 27, 2021
@engine-flutter-autoroll
f7ee663 Remove exoplayer workaround from everything but video_player (f…
6446575 
…lutter/plugins#3980)
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
@yasargil
Merge branch 'master' into gmain
9d6ff71 
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
Remove exoplayer workaround from everything but video_player (flutter…
8aa11e7 
…#3980)

Now that video_player includes this workaround at the plugin level, it's no longer necessary in the examples that use it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
cla: yes p: camera p: image_picker platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @jmagman