Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[script/tool] Use 'dart pub' instead of deprecated 'pub' #3991

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

mrhota
Copy link
Contributor

@mrhota mrhota commented May 30, 2021

Because I'm new to dart and flutter, I never had a pub binary installed. Running dart run script/tool/lib/src/main.dart test crashed on the plugin_platform_interface tests because that package doesn't qualify as a flutter package. The log message at the point of failure hinted at the cause:

RUNNING plugin_platform_interface tests...
Running command: "pub get" in /Users/aj/dev/flutter_plugins/packages/plugin_platform_interface
Unhandled exception:
ProcessException: No such file or directory
  Command: pub get
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:390:33)
#1      Process.start (dart:io-patch/process_patch.dart:36:20)
#2      ProcessRunner.runAndStream (package:flutter_plugin_tools/src/common.dart:540:49)
#3      TestCommand.run (package:flutter_plugin_tools/src/test_command.dart:68:40)
<asynchronous suspension>
#4      CommandRunner.runCommand (package:args/command_runner.dart:196:13)
<asynchronous suspension>
#5      main.<anonymous closure> (package:flutter_plugin_tools/src/main.dart)
<asynchronous suspension>

List which issues are fixed by this PR. You must list at least one issue.
I couldn't find one. This is a test/tool infrastructure fix.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 30, 2021
@mrhota
Copy link
Contributor Author

mrhota commented Jun 1, 2021

I don't know why the submit-queue check failed here.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

The submit-queue redness looks like Cirrus didn't report status back correctly for the last commit on master.

@stuartmorgan-g stuartmorgan-g merged commit 8430ecb into flutter:master Jun 1, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2021
yasargil added a commit to yasargil/plugins that referenced this pull request Jun 2, 2021
* master: (131 commits)
  [in_app_purchase] fix "autoConsume" param in "buyConsumable" (flutter#3957)
  [video_player_web] fix: set autoplay to false during initialization (flutter#3985)
  [multiple_web] Adapt web PlatformView widgets to work slotted. (flutter#3964)
  [url_launcher] Add iOS unit and UI tests (flutter#3987)
  [image_picker] Change storage location for camera captures to internal cache on Android, to comply with new Google Play storage requirements.  (flutter#3956)
  [script/tool] Use 'dart pub' instead of deprecated 'pub' (flutter#3991)
  [video_player] Add iOS unit and UI tests (flutter#3986)
  Add pubspec convention checks (flutter#3984)
  Enable pubspec dependency sorting lint (flutter#3983)
  [image_picker] Migrate maven repo from jcenter to mavenCentral (flutter#3915)
  [video_player] Update README.md (flutter#3975)
  [script/tool] speed up the pub get portion of the analyze command (flutter#3982)
  Revert commit e742a7b (flutter#3976)
  Added support to request list of purchases (flutter#3944)
  [google_maps_flutter] Add iOS unit and UI tests (flutter#3978)
  Added Windows to the description (flutter#3936)
  use 'flutter pub get' for both dart and flutter packages (flutter#3973)
  [camera] android-rework part 3: Android exposure related features (flutter#3797)
  Remove exoplayer workaround from everything but video_player (flutter#3980)
  Allow reverts when checking versions (flutter#3981)
  ...
@mrhota mrhota deleted the fix-plugin-test-command branch June 3, 2021 22:32
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants