-
Notifications
You must be signed in to change notification settings - Fork 108
Add installation script in install.sh #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation script in install.sh #206
Conversation
Adds recursive source discovery for local path dependencies
Currently always built.
Now supported with local dev-dependencies
Local dependency paths are relative to the dependent package not the building package.
There's a bug which causes app-local modules to be added twice if auto-discovery is on and the app is specified in the manifest. This causes the module to be compiled and linked twice. Not detected before because the module contained no symbols. This commit adds an integer symbol to an app-local module to test this bug.
Demonstrates bug in include statement parsing - currently erroneously parsing all statements that begin with 'include'.
Include statements must have a single or double quote immediately following 'include'
Demonstrates bug in include statement parsing - currently erroneously parsing all statements that begin with 'include'.
Include statements must have a single or double quote immediately following 'include'
Co-authored-by: Milan Curcic <[email protected]>
Thanks @rouson for sending it. I think this only works on Linux? |
@certik it was developed on macOS. The goal will be for it to also work on Linux (I'll test it on Lubuntu) and on the Windows Subsystem for Linux (which I'll eventually test too but I'm not sure of the timeline as I need to purchase Windows). Also, this first version is skeletal. Over time, I'll attempt to make it more robust and add features. For example, I'll add
If you have other requested features, let me know and feel free to submit issues. In theory, I can borrow a lot from the OpenCoarrays installer, but that installer is written in |
Minor fixes: to list_files and mkdir in fpm_filesystem
…ap_submodule_support Bootstrap submodule support
Co-authored-by: Brad Richardson <[email protected]>
Hold on, I think a mistake was made in this PR. It seems to include tons of unrelated changes. @everythingfunctional did you merge more things by a mistake? When you update a PR, please ask for another review. We should be merging PRs with a nice git history that only do one thing. This PR, at least according to GitHub is mixing together many unrelated changes. It could also be just a mistake at GitHub, but in that case we should simply rebase on top of the latest master to ensure the PR is small and in this case only includes the |
I think what Github is now showing after-the-fact is not correct. (I'm pretty sure) when I clicked merge, the only change showing was the addition of the |
Before you merged, master was at the commit: 4443986, which is fine. This PR was at a commit cda71a0, and when you clicked "Merge", GitHub added the merge commit a22ce1c, which is now the latest master. If you look at cda71a0 (i.e., this PR) and the history in there, this is what I see:
So it seems it is not clean --- the commits are there twice, such as b44b567 and e331951, etc. I don't quite understand how it happened, but it does not seem right. Anyway, we can probably keep it, since the alternative is to revert this. |
No description provided.