Update Linter for Windows #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous revision to errorRegex removed support for \r\n line endings. This change uses \s* to match all whitespace between the lines in the error message which shoul eliminate this problem in the future. Also, the previous version only allowed uppercase drive letters and my system reported lowercase (ie. c:\) which caused the matching to fail.
If no include paths are specified in the configuration, getIncludeParams would return "-I" which would be included in the list of gfortran arguments. This appeared directly before the file path which caused gfortran to complain that no input files were specified. This change allows the include path specification to be removed if there are no include paths specified.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 18.9% 18.77% -0.13%
==========================================
Files 9 9
Lines 291 293 +2
Branches 32 33 +1
==========================================
Hits 55 55
- Misses 236 238 +2
Continue to review full report at Codecov.
|
The EXIT keyword was added along with the CYCLE keyword to control the program flow within loops. EXIT is equivalent to `break` in C/C++.
|
This sounds quite good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some problems getting the gfortran-based linter to work on Windows 10 so I took a stab at fixing the problems.
Issues:
fortran.includePathsthengfortranto complains about no input files and exitserrorRegexfails to matchgfortranoutput so no errors are displayedChanges:
getIncludeParamsfunction insrc/lib/helper.tsto check for thepathsvariable having a length of 0. In this case the function returns""instead of"-I ". The empty argument will then be removed byconstructArgumentListinsrc/features/linter-provider.ts.errorRegexinsrc/features/linter-provider.tsto allow for upper and lowercase drive names on Windows and to match all space between output lines via\s+instead of just\n. The change to matching space should allow the regex to work regardless of the operating system using carriage returns or not.I ran the extension tests on my Windows 10 computer and all 13 passed. Unfortunately, I don't have quick access to a linux system for testing, but I can create a VM if necessary.