Skip to content

Temporary remove Experimental Language Fortran setting #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

pedro-ricardo
Copy link
Collaborator

Follow a recommendation from #105 to avoid issues like #114 #119.
Users are trying to use the feature and getting errors, also the FORTRAN IntelliSense extension exists to add that support.

Steps

  • The README.md part was commented
  • The setting on package.json was removed
  • The usage of this configuration in lang-server.ts was commented and hard-coded as false

@pedro-ricardo pedro-ricardo changed the base branch from master to release/2.1.0 March 16, 2019 13:47
@pedro-ricardo pedro-ricardo requested a review from krvajal March 16, 2019 16:01
@pedro-ricardo
Copy link
Collaborator Author

@krvajal Will this one be merged?

README.md Outdated
@@ -89,7 +89,7 @@ This is a list of some of the snippets included, if you like to include addition
## Error wiggles

To trigger code validations you must save the file first.

<!--
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove it, there is no need for a comment. If we want it back, we have it in the previous commits. That's what version control is for ;)

@pedro-ricardo
Copy link
Collaborator Author

OK done 👍

@pedro-ricardo pedro-ricardo merged commit 9aa401b into release/2.1.0 Mar 20, 2019
@pedro-ricardo pedro-ricardo deleted the hotfix/lang_server branch March 20, 2019 14:11
krvajal pushed a commit that referenced this pull request Mar 26, 2019
### Check List
- [x] Merge #120 suggestion of #105
- [x] Merge #112 for fix on issue #110
- [x] Merge #117 for fix on issue #115
- [x] Merge #118 for fix on issue #116
- [x] Merge #122 for fix on issue #113
- [x] Update CHANGELOG.md
- [x] Update Package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants