Support for Formatting #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The file structures have been updated to abide with the latest config syntax - Updated build commands in package.json - Deleted tasks.json.old
Regenerated npm and yarn .json files
The OpenMP regex did not allow for the OpenACC syntax scope to trigger. This has now been fixed and both should be displayed correctly. The only outstanding problem is that the unittest (.snap) does not trigger the right scopes, which means open acc/openmp are not tested thoroughly. I look into it
Changes all fortls instances with global variable and makes pip install user based with upgrade.
Closed
This was
linked to
issues
Oct 1, 2021
Having preceding characters to ``` caused a problem in the hover result
gnikit
force-pushed
the
feature/formatting
branch
from
dfe2d4c to
7129299
Compare
Fixes Setting up VSCE releases from GitHub releases #237
Fixes Rename fortran_fixed-form to FortranFixedForm #259
Fixes Extension does not activate for FixedForm #257
Fixes Linting does not work for fixed format files #258
1. Fixes conditional trigger for linting 2. Moves which as a dependency 3. Adds logging output for when parts of the extension are enabled
gnikit
force-pushed
the
feature/formatting
branch
from
ffeda02 to
251fb79
Compare
This was
unlinked from
issues
Nov 12, 2021
|
So all the changes for this one (vs-icons) and all the other deps that we have had are now in master so if @krvajal you are okay with this I will merge it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for formatting of both free-form and fixed-form Fortran and Fixes #29.
Two formatters have been added,
findentandfprettify.findentis a performant, relatively mature formatter written in C++,while
fprettifyis a newer formatter written in Python.The ability to also install our dependencies has also been added, with the exception of
fidentthat does not currently have a particularly user-friendly installer (depending on the OS you can install it through a PPA with sudo access but this is a massive security issue)Due to us being able to use now
findenta series of other features are also available likemake)Downloading the formatters
Both formatters can be installed through pip, e.g.
pip install findentorpip install fprettifyFor problems with the installation of
fidentthrough pip please go to: https://github.com/gnikit/findent-pypiTODO
findentto be installed through pip--align-paren=1as an input argument.fprettifycan only be used with F90+Other Changes
paths.tsand replaced withwhich, there is no measurable performance difference for not caching thefortlspath see 4bc2d04fortran_fixed-formtoFortranFixedFormThe changes to the fixed form, language ID, activation and linting were made because with the way the extension was setup we could not spawn a formatter for fixed form fortran.