Eslint #275
Merged
Eslint #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Change tslint to eslint #260
The lint-stage hook sould now be able to work when we commit. If a commit fails then run `npm run lint-fix` to try and autofix and then `npm run format`. All of these actions should be run automatically via the git hook but I am listing the steps in case the hook fails.
Closed
Closed
VSCode had trouble parsing the `printWidth` and kept defaulting to 100 which in turn caused the formatter in VSCode to produce different results than `npm run format`. An autofix attempt has also been added when `lint-stage`ing
|
@krvajal You might want to have a look but given that these are changes brought by the linting/formatting tools along with normal maintenance work it is not that important. I will be merging this branch soon, once I manage to update the husky git hook from v4 to v7. |
|
I will leave the husky to v4 because I would have to update my local npm version to 7.x. Last time I did that I had problems with compiling the extension and hence I had to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes