Eslint formatting #261
Closed
Eslint formatting #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has now been replaced with `which` which is also platform agnostic. The only difference is that `which` does not cache the result of the query. However, realistically speaking calling which once per new file being opened is a trivial cost. Moreover, already opened files are cached automatically so no `which` calls are made when changing between opened files.
We now prompt the user to install fortran-language-server and Fortran IntelliSense if the packages are missing. There is a slight issue with the calls being asynchronous, so if they are installed in the wrong order Fortran IntelliSense first and then fortls an error is being throw.
Adds support for `findent` and `fprettify`. Fixes #29.
Fixes Rename fortran_fixed-form to FortranFixedForm #259
Fixes Extension does not activate for FixedForm #257
Fixes Linting does not work for fixed format files #258
Added back the husky and lint-staged although we don't really use them. The name of Function had to be changed to FortranFunction since it clashed with the TypeScript Function. The `parseMe` var in the interface was deleted since it was never used and it was causing errors due to the SymbolParser interface being empty.
gnikit
force-pushed
the
feature/formatting
branch
4 times, most recently
from
ffeda02 to
251fb79
Compare
|
closed in favour of #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eslint formatting and removed deprecated tslint
I left husky and lint-staged inside even though we do not really use them. If we want to, we should also add prettier and eslint-prettier...
Fixes #260