Check tag names breaking #303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golopot
reviewed
Jun 30, 2019
brettz9
force-pushed
the
check-tag-names-breaking
branch
2 times, most recently
from
7684dcc to
fd92de0
Compare
… to be defined; add `definedTags` option to replace `additionalTagNames.customTags` setting BREAKING CHANGE: Switch `additionalTagNames.customTags` setting to `definedTags` option (only used by one rule)
brettz9
force-pushed
the
check-tag-names-breaking
branch
from
fd92de0 to
9df41d7
Compare
golopot
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(check-tag-names): auto-allow tags in
tagNamePreferencesetting to be defined; adddefinedTagsoption to replaceadditionalTagNames.customTagssettingBREAKING CHANGE:
Switch
additionalTagNames.customTagssetting todefinedTagsoption (only used by one rule)