Remove preferredTypesDefined option, applying it automatically instead
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be defined; add `definedTags` option to replace `additionalTagNames.customTags` setting BREAKING CHANGE: Switch `additionalTagNames.customTags` setting to `definedTags` option (only used by one rule)
golopot
approved these changes
Jul 5, 2019
There was a problem hiding this comment.
I have change the merge target branch to 11.0, as discussed in #303 (comment) .
brettz9
force-pushed
the
remove-preferredTypesDefined
branch
from
9939343 to
505f1d7
Compare
…ly automatically BREAKING CHANGE: One can no longer avoid `preferredTypes` types being treated as defined
brettz9
force-pushed
the
remove-preferredTypesDefined
branch
from
505f1d7 to
2072735
Compare
|
It seems that this pr is accidental closed because the branch |
|
I had already added an 11.0.0 branch and rebased this onto that. It won't let me reopen as this is already a part of 11.0.0. There are no new changes, I have simply rebased, so if you want to confirm, please confirm on 11.0.0. I've also merged in #310 as you approved that as well. |
|
Ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add along with #302 and #303 to an
11.0.0branch per #303 (comment) before merging.feat: make
preferredTypesDefinedoption obsolete by applying the behavior automaticallyBREAKING CHANGE:
One can no longer set
preferredTypesDefinedtofalseto avoid thesettings.jsdoc.preferredTypestargets from being treated as defined.