Skip to content

Check syntax closure #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Check syntax closure #589

merged 1 commit into from
Jun 23, 2020

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented Jun 21, 2020

Builds on #587 and #588.

feat(check-syntax): only check against Closure syntax in "jsdoc" and "typescript" mode; fixes part of #356

"jsdoc" mode or new "permissive" mode will not complain (in preparation for the rule potentially preventing other syntaxes by mode (where jsdoctypeparser does not forbid)).

@brettz9 brettz9 requested a review from golopot June 21, 2020 05:21
This was referenced Jun 21, 2020
…d "typescript" mode; fixes part of gajus#356

"jsdoc" mode or new "permissive" mode will not complain (in preparation for the rule potentially preventing other syntaxes by mode (where jsdoctypeparser does not forbid)).
@brettz9 brettz9 force-pushed the check-syntax-closure branch from 1ca1892 to 85d98ce Compare June 23, 2020 05:33
@brettz9 brettz9 merged commit 8dfdd0b into gajus:master Jun 23, 2020
@gajus
Copy link
Owner

gajus commented Jun 23, 2020

🎉 This PR is included in version 28.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jun 23, 2020
@brettz9 brettz9 deleted the check-syntax-closure branch June 23, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants