Skip to content

Valid types #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Valid types #591

merged 4 commits into from
Jun 23, 2020

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented Jun 21, 2020

Builds on #587, #588, #589, and #590.

feat(valid-types): for extends, package and access tags (e.g., private), report bracketed type in non-Closure mode

Also reports missing name with typedef in non-Closure mode

@brettz9 brettz9 requested a review from golopot June 21, 2020 05:29
@brettz9 brettz9 force-pushed the valid-types branch 3 times, most recently from 3ca4985 to 9c1e679 Compare June 23, 2020 05:46
brettz9 added 4 commits June 23, 2020 13:56
…`private`), report bracketed type in non-Closure mode; fixes gajus#356

Also reports missing name with `typedef` in non-Closure mode
…fault to `typescript` when `typescript-eslint/parser` is on; fixes gajus#593
@brettz9 brettz9 merged commit 37cb092 into gajus:master Jun 23, 2020
@gajus
Copy link
Owner

gajus commented Jun 23, 2020

🎉 This PR is included in version 28.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jun 23, 2020
@brettz9 brettz9 deleted the valid-types branch June 23, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants