closes #389 - Create api/lessons page that returns object of lessons data #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject of lessons data
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/ggpmwfy6z |
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 81 82 +1
Lines 1030 1037 +7
Branches 231 231
=========================================
+ Hits 1030 1037 +7
|
ggwadera
approved these changes
Sep 7, 2020
…ns function from graphql/queryResolvers folder upon import
songz
approved these changes
Sep 8, 2020
songz
reviewed
Sep 8, 2020
| export default async (_: LoggedRequest, res: NextApiResponse) => { | ||
| try { | ||
| const allLessons = await lessons() | ||
| res.status(200) |
There was a problem hiding this comment.
by default, res.json already has status 200, so unnecessary.
songz
reviewed
Sep 8, 2020
| throw new Error('Error occured :(') | ||
| }) | ||
| await lessonsAPI(null, res) | ||
| expect(res.json).toBeCalledWith('Error occured :(') |
There was a problem hiding this comment.
this and previous test could be combined
songz
reviewed
Sep 8, 2020
|
|
||
| test('should respond with 200 status code when there is no error', async () => { | ||
| await lessonsAPI(null, res) | ||
| expect(res.status).toBeCalledWith(200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page needs to be created, as the API is used in examples in the c0d3 curriculum
This PR will:
api/lessonspage that returns an object containing the same data the lessons API for version 1 of code returned.