-
Notifications
You must be signed in to change notification settings - Fork 71
closes #389 - Create api/lessons page that returns object of lessons data #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5a9218e
closes #389 - init commit, create api/lessons page that returns an ob…
bd00fe3
closes #389 - create tests for lessons api
37be506
closes #387 - update mock lessons value to a less boring value
6645da7
closes #387 - remove name from function in order to destructure lesso…
653cd11
closes #387 - add tests and account for failure with try catch block
fac4e20
closes #387 - update error message to include frown face
f9d1aef
closes #387 - clean up duplicate code in testing file
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import lessonsAPI from './lessons' | ||
import noop from '../../helpers/noop' | ||
import * as getLessons from '../../graphql/queryResolvers/lessons' | ||
|
||
describe('lessonsAPI', () => { | ||
const res = { | ||
json: jest.fn(noop), | ||
status: jest.fn(noop) | ||
} | ||
|
||
getLessons.lessons = jest | ||
.fn() | ||
.mockReturnValue(['man', 'bear', 'pig', 'manbearpig']) | ||
|
||
test('should respond with 200 status code when there is no error', async () => { | ||
await lessonsAPI(null, res) | ||
expect(res.status).toBeCalledWith(200) | ||
}) | ||
|
||
test('should respond with json data from lessons() when there is no error', async () => { | ||
await lessonsAPI(null, res) | ||
expect(res.json).toBeCalledWith(['man', 'bear', 'pig', 'manbearpig']) | ||
}) | ||
|
||
test('should respond with 500 status code when there is an error', async () => { | ||
getLessons.lessons = jest.fn().mockImplementation(() => { | ||
throw new Error('Error') | ||
}) | ||
await lessonsAPI(null, res) | ||
expect(res.status).toBeCalledWith(500) | ||
}) | ||
|
||
test('should respond with error message when there is an error', async () => { | ||
getLessons.lessons = jest.fn().mockImplementation(() => { | ||
throw new Error('Error occured :(') | ||
}) | ||
await lessonsAPI(null, res) | ||
expect(res.json).toBeCalledWith('Error occured :(') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this and previous test could be combined |
||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { lessons } from '../../graphql/queryResolvers/lessons' | ||
import { LoggedRequest } from '../../@types/helpers' | ||
import { NextApiResponse } from 'next' | ||
|
||
export default async (_: LoggedRequest, res: NextApiResponse) => { | ||
try { | ||
const allLessons = await lessons() | ||
res.status(200) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. by default, |
||
res.json(allLessons) | ||
} catch (err) { | ||
res.status(500) | ||
res.json('Error occured :(') | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need