-
Notifications
You must be signed in to change notification settings - Fork 0
port OCI module back from python_gardenlinux_cli #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5fd8d5
to
cf377b1
Compare
b45b17f
to
6847121
Compare
c50c3ad
to
43f8e8d
Compare
NotTheEvilOne
requested changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
on main after merging of #106 to prevent commits included in the other PR as well.
43f8e8d
to
9e916b2
Compare
67ca802
to
49d0a52
Compare
NotTheEvilOne
requested changes
May 22, 2025
49d0a52
to
cefdaa4
Compare
NotTheEvilOne
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Further improvements will be tracked in #110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Port the oci module and cli from https://github.com/gardenlinux/python-gardenlinux-cli back to this lib.
This is supposed to be useful for future code that the
oci
module and thegl-oci
cli from this library instead.based on #106