allow adding additional tags to OCI index and manifests #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoldegrove
changed the title
yeoldegrove
force-pushed
the
feat/oci_tagging
branch
4 times, most recently
from
db91efb to
8bc6eea
Compare
yeoldegrove
force-pushed
the
feat/oci_tagging
branch
from
8bc6eea to
01c7621
Compare
adds the possibility to get debug logs for pytest e.g. debug which OCI tags exist
add create_test_data to conftest remove generate_test_certificates from helper as it is on conftest already
enables pushing additional tags to OCI manifest
enables pushing additional tags to OCI index
yeoldegrove
force-pushed
the
feat/oci_tagging
branch
from
01c7621 to
9715853
Compare
NotTheEvilOne
requested changes
May 22, 2025
| for artifact in oci_metadata: | ||
| if artifact["media_type"] == "application/io.gardenlinux.release": | ||
| file = open(f"{directory}/{artifact["file_name"]}", "r") |
There was a problem hiding this comment.
Please use configparser.ConfigParser here as it will be compatible with the file content and makes the code more readable :)
There was a problem hiding this comment.
Can we name this file wrapper(s).py? Further refinement can be integrated into #110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
gardenlinux/gardenlinux#2754 outlines the restructure of OCI release tags.
To actually add additional tags to the OCI index and manifests, a new paramter
--additional-taghas to be added to thegl-oci update-index|push-manifestcalls.Additionally this adds:
make test-debugandmake test-traceto debug OCI taggingSpecial notes for your reviewer: