This repository was archived by the owner on Aug 30, 2023. It is now read-only.
migration(plugins): removes all plugins except slack and PD #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
reviewed
Nov 6, 2019
| @@ -11,10 +11,6 @@ def pytest_configure(config): | |||
| # Note: We could manually register/configure INSTALLED_APPS by traversing our entry points | |||
| # or package directories, but this is easier assuming Sentry doesn't change APIs. | |||
| # Note: Order of operations matters here. | |||
| from sentry.runner.importer import install_plugin_apps | |||
|
|
|||
| install_plugin_apps("sentry.apps", settings) | |||
There was a problem hiding this comment.
Why did this get removed? Do slack/pd not need to be added to INSTALLED_APPS by sentry's importer?
There was a problem hiding this comment.
Actually yeah, seems like we should keep this since there are still a couple plugins in sentry.apps
There was a problem hiding this comment.
@wedamija @joshuarli Hmmm? The only ones in that list were Jira, Jira AC, and SessionStack. All of those are now in sentry-core which has the entrypoint of sentry.new_apps.
There was a problem hiding this comment.
@scefali Ah you're right, I understand now.
wedamija
approved these changes
Nov 6, 2019
joshuarli
approved these changes
Nov 6, 2019
scefali
pushed a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with getsentry/sentry#15468
Must be merged after: https://github.com/getsentry/getsentry/pull/3309