Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

migration(plugins): removes all plugins except slack and PD #538

Merged
merged 2 commits into from
Nov 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ def pytest_configure(config):
# Note: We could manually register/configure INSTALLED_APPS by traversing our entry points
# or package directories, but this is easier assuming Sentry doesn't change APIs.
# Note: Order of operations matters here.
from sentry.runner.importer import install_plugin_apps

install_plugin_apps("sentry.apps", settings)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this get removed? Do slack/pd not need to be added to INSTALLED_APPS by sentry's importer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yeah, seems like we should keep this since there are still a couple plugins in sentry.apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wedamija @joshuarli Hmmm? The only ones in that list were Jira, Jira AC, and SessionStack. All of those are now in sentry-core which has the entrypoint of sentry.new_apps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scefali Ah you're right, I understand now.


from sentry.runner.initializer import register_plugins

register_plugins(settings)
Expand Down
28 changes: 0 additions & 28 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,33 +51,24 @@
class BuildAssetsCommand(BuildAssetsCommand):
def get_dist_paths(self):
return [
"src/sentry_plugins/jira/static/jira/dist",
]


class SentrySDistCommand(SDistCommand):
sub_commands = SDistCommand.sub_commands + [("build_assets", None)]

def run(self):
cmd_obj = self.distribution.get_command_obj("build_assets")
cmd_obj.asset_json_path = "sentry_plugins/assets.json"
SDistCommand.run(self)


class SentryBuildCommand(BuildCommand):
def run(self):
BuildCommand.run(self)
cmd_obj = self.distribution.get_command_obj("build_assets")
cmd_obj.asset_json_path = "sentry_plugins/assets.json"
self.run_command("build_assets")


class SentryDevelopCommand(DevelopCommand):
def run(self):
DevelopCommand.run(self)
cmd_obj = self.distribution.get_command_obj("build_assets")
cmd_obj.asset_json_path = "sentry_plugins/assets.json"
self.run_command("build_assets")


cmdclass = {
Expand All @@ -104,28 +95,9 @@ def run(self):
extras_require={"tests": tests_require},
include_package_data=True,
entry_points={
"sentry.apps": [
"jira_ac = sentry_plugins.jira_ac",
"jira = sentry_plugins.jira",
],
"sentry.plugins": [
"asana = sentry_plugins.asana.plugin:AsanaPlugin",
"bitbucket = sentry_plugins.bitbucket.plugin:BitbucketPlugin",
"clubhouse = sentry_plugins.clubhouse.plugin:ClubhousePlugin",
"github = sentry_plugins.github.plugin:GitHubPlugin",
"gitlab = sentry_plugins.gitlab.plugin:GitLabPlugin",
"heroku = sentry_plugins.heroku.plugin:HerokuPlugin",
"jira = sentry_plugins.jira.plugin:JiraPlugin",
"jira_ac = sentry_plugins.jira_ac.plugin:JiraACPlugin",
"pagerduty = sentry_plugins.pagerduty.plugin:PagerDutyPlugin",
"phabricator = sentry_plugins.phabricator.plugin:PhabricatorPlugin",
"pivotal = sentry_plugins.pivotal.plugin:PivotalPlugin",
"pushover = sentry_plugins.pushover.plugin:PushoverPlugin",
"segment = sentry_plugins.segment.plugin:SegmentPlugin",
"slack = sentry_plugins.slack.plugin:SlackPlugin",
"splunk = sentry_plugins.splunk.plugin:SplunkPlugin",
"victorops = sentry_plugins.victorops.plugin:VictorOpsPlugin",
"vsts = sentry_plugins.vsts.plugin:VstsPlugin",
],
},
classifiers=[
Expand Down
8 changes: 0 additions & 8 deletions src/sentry_plugins/asana/README.rst

This file was deleted.

1 change: 0 additions & 1 deletion src/sentry_plugins/asana/__init__.py

This file was deleted.

33 changes: 0 additions & 33 deletions src/sentry_plugins/asana/client.py

This file was deleted.

233 changes: 0 additions & 233 deletions src/sentry_plugins/asana/plugin.py

This file was deleted.

14 changes: 0 additions & 14 deletions src/sentry_plugins/bitbucket/README.rst

This file was deleted.

5 changes: 0 additions & 5 deletions src/sentry_plugins/bitbucket/__init__.py

This file was deleted.

Loading