iOS: native support #254

bitsandfoxes · 2021-07-13T13:46:47Z

First working iteration on our iOS Native Support:

Restore Cocoa submodule if missing
Build/Clean Cocoa SDK targets (dotnet msbuild /t:BuildCocoaSDK \ CleanCocoaSDK)
Copy Sentry.framework into package-dev
Hook into Unity Xcode generation during build post process and add the Sentry SDK
Generate native options dictionary and fill it with the appropriate values read from ScriptableSentryOptions
Hook into main and initialize the SDK

src/Sentry.Unity.Editor.iOS/BuildPostprocess.cs

bruno-garcia

nice tests

package-dev/Tests/Editor/TestFiles/main_2019_4_expected.txt

samples/unity-of-bugs/Assets/Plugins/Sentry/SentryOptions.txt

src/Sentry.Unity.Editor.iOS/MainModifier.cs

test/Sentry.Unity.Editor.iOS.Tests/Sentry.Unity.Editor.iOS.Tests.csproj

Directory.Build.targets

scripts/build-cocoa-sdk.sh

src/Sentry.Unity.Editor.iOS/BuildPostProcess.cs

src/Sentry.Unity.Editor.iOS/NativeMain.cs

bruno-garcia · 2021-08-03T14:26:47Z

src/Sentry.Unity.Editor.iOS/NativeOptions.cs

+// IMPORTANT: Changes to this file will be lost!
+// This file is generated during the Xcode project creation.
+
+// TODO: make pretty with link to docs


src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs

bruno-garcia · 2021-08-03T14:54:54Z

Good stuff! Left suggestions for some minor improvements but this is great!

bruno-garcia

🚀

Directory.Build.targets

bruno-garcia · 2021-08-03T15:31:15Z

samples/unity-of-bugs/Assets/Resources/Sentry/SentryOptions.asset

  <ShutdownTimeout>k__BackingField: 2000
  <MaxQueueItems>k__BackingField: 30
+  <IOSNativeSupportEnabled>k__BackingField: 1


We need to consider the upgrade path. Where this field doesn't exist and will default to 0.
Perhaps have it nullable so we can tell if the user opt-ed out or if it's just an upgrading scriptable objet

src/Sentry.Unity.Editor.iOS/BuildPostProcess.cs

test/Sentry.Unity.Editor.iOS.Tests/NativeMainTests.cs

test/Sentry.Unity.Editor.iOS.Tests/Sentry.Unity.Editor.iOS.Tests.csproj

test/Sentry.Unity.Editor.iOS.Tests/SentryXcodeProjectTests.cs

…-unity into feat/ios_native

bruno-garcia

Awesome stuff! I left some minor notes but we could merge and address other things in follow up PRs

src/Sentry.Unity.Editor.iOS/BuildPostProcess.cs

src/Sentry.Unity.Editor.iOS/NativeOptions.cs

src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs

src/Sentry.Unity/SentryUnityOptionsExtensions.cs

test/Sentry.Unity.Editor.iOS.Tests/NativeMainTests.cs

test/Sentry.Unity.Editor.iOS.Tests/NativeOptionsTests.cs

test/Sentry.Unity.Editor.iOS.Tests/SentryXcodeProjectTests.cs

added build post process for xcode

1ca5f10

bitsandfoxes added the Feature New feature or request label Jul 13, 2021

bitsandfoxes self-assigned this Jul 13, 2021

bitsandfoxes added 6 commits July 13, 2021 15:52

fixed pathing

e7e8479

moved ios post processing into new proj

88ef4d5

cleanup

0908f67

Merge branch 'main' into feat/ios_native

61e7737

added Editor.iOS to solution

1bbc257

renamed post process

ef0fa15

bruno-garcia reviewed Jul 17, 2021

View reviewed changes

src/Sentry.Unity.Editor.iOS/BuildPostprocess.cs Outdated Show resolved Hide resolved

src/Sentry.Unity.Editor.iOS/BuildPostprocess.cs Outdated Show resolved Hide resolved

bitsandfoxes added 13 commits July 22, 2021 18:32

stabilize

c01b417

stabilize cleanup

75326d3

first wip dictionary

64f6b30

Merge branch 'main' into feat/ios_native

20c4fbd

split build post process up

f929999

split main modifier and added tests

e2d6653

removed temp files

1996527

added cocoa as submodule

dd91db5

added cocoa build to buildtargets

65c0381

removed .framework from assets

5d716e9

removed framework meta from gitignore for iOS targeting

644ba52

fixed cocoa clean

62884dd

fixed plugin path

3849c0f

bruno-garcia reviewed Jul 29, 2021

View reviewed changes

package-dev/Tests/Editor/TestFiles/main_2019_4_expected.txt Outdated Show resolved Hide resolved

samples/unity-of-bugs/Assets/Plugins/Sentry/SentryOptions.txt Outdated Show resolved Hide resolved

src/Sentry.Unity.Editor.iOS/MainModifier.cs Outdated Show resolved Hide resolved

bruno-garcia reviewed Jul 29, 2021

View reviewed changes

test/Sentry.Unity.Editor.iOS.Tests/Sentry.Unity.Editor.iOS.Tests.csproj Outdated Show resolved Hide resolved

bitsandfoxes added 5 commits July 29, 2021 17:53

added native options generation tests

9a99d5c

tweaked native options generation

45af472

added more options to native options

fc025b2

newlines are the worst.. -.-

db2d3bb

csproj cleanup

718108a

cleanup

d380e9b

bruno-garcia marked this pull request as ready for review August 3, 2021 13:12

bruno-garcia requested a review from semuserable as a code owner August 3, 2021 13:12

CI iOS module test

3db5ce8

bruno-garcia reviewed Aug 3, 2021

View reviewed changes

bitsandfoxes added 2 commits August 3, 2021 17:08

review

a8a5ac5

review #2

ca080e7

bruno-garcia closed this Aug 3, 2021

bruno-garcia reopened this Aug 3, 2021

Merge branch 'main' into feat/ios_native

0d16af3

bruno-garcia reviewed Aug 3, 2021

View reviewed changes

bitsandfoxes added 9 commits August 4, 2021 18:43

review

867fec3

Merge branch 'feat/ios_native' of https://github.com/getsentry/sentry…

edd6ec7

…-unity into feat/ios_native

moved building cocoa into build.targets

67382e8

moar review

7c45a87

fixed ios tool path for editor.ios

f9896b2

fixed pii option name in native options

253484a

skip copying unchanged files

a206db2

replaced copy testfiles target with built-in itemgroup

dc822a9

excluded clang tests for non MacOSX platforms

484fd99

bruno-garcia approved these changes Aug 5, 2021

View reviewed changes

bitsandfoxes added 5 commits August 5, 2021 18:35

review fixes

75b5d44

updated CHANGELOG.md

5a07dec

added missing cocoa submodule restoration

1d8fbde

fixed inconsistent paths

801f50f

fixed restoring submodules

36b135c

bitsandfoxes merged commit 3c129a3 into main Aug 6, 2021

bitsandfoxes deleted the feat/ios_native branch August 6, 2021 09:12

bitsandfoxes mentioned this pull request Aug 20, 2021

Support native iOS crashes #164

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS: native support #254

iOS: native support #254

bitsandfoxes commented Jul 13, 2021 •

edited

Loading

bruno-garcia left a comment

bruno-garcia Aug 3, 2021

bruno-garcia commented Aug 3, 2021

bruno-garcia left a comment

bruno-garcia Aug 3, 2021

bruno-garcia left a comment

iOS: native support #254

iOS: native support #254

Conversation

bitsandfoxes commented Jul 13, 2021 • edited Loading

bruno-garcia left a comment

Choose a reason for hiding this comment

bruno-garcia Aug 3, 2021

Choose a reason for hiding this comment

bruno-garcia commented Aug 3, 2021

bruno-garcia left a comment

Choose a reason for hiding this comment

bruno-garcia Aug 3, 2021

Choose a reason for hiding this comment

bruno-garcia left a comment

Choose a reason for hiding this comment

bitsandfoxes commented Jul 13, 2021 •

edited

Loading