-
-
Notifications
You must be signed in to change notification settings - Fork 52
Add native local scope for Windows/Linux #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
df159c9
Set local scope branch for sentry-native submodule
tustanivsky b9d7d94
Update changelog
tustanivsky 0690dd4
Bump submodule
tustanivsky 6434596
Bump submodule again
tustanivsky d914c5a
Add local scope implementation for desktop
tustanivsky 40b0774
Fix lint errors
tustanivsky f2bb0ed
Fix
tustanivsky 7a0f5dc
Include order
tustanivsky df4cbe2
Revert scope data caching on Unreal's side
tustanivsky 507be99
Merge branch 'main' into feat/local-scope-desktop
tustanivsky 74b0419
Fix lint errors
tustanivsky 1fd94a6
Remove env and dist setters from scope class
tustanivsky 79fc0bc
Merge branch 'feat/local-scope-desktop' of github.com:getsentry/sentr…
tustanivsky 5eee756
Update changelog
tustanivsky 556c3b4
Remove ConfigureScope function
tustanivsky 7f9c65e
Update changelog
tustanivsky b418ebd
Remove redundant array size checks
tustanivsky e79bd84
Free memory after capturing event with local scope
tustanivsky 15fc482
Bump submodule
tustanivsky 269a4e2
Merge branch 'main' into feat/local-scope-desktop
tustanivsky 946a510
Remove sentry_scope_free calls as this API was deleted in native
tustanivsky ddf3a09
Fix blueprint errors
tustanivsky 68e25f6
Merge branch 'main' into feat/local-scope-desktop
tustanivsky d676b55
Update CHANGELOG.md
tustanivsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule sentry-native
updated
9 files
+1 −2 | CHANGELOG.md | |
+5 −18 | CMakeLists.txt | |
+1 −1 | external/crashpad | |
+2 −3 | include/sentry.h | |
+1 −1 | ndk/gradle.properties | |
+1 −1 | src/CMakeLists.txt | |
+2 −2 | tests/assertions.py | |
+1 −1 | tests/test_integration_http.py | |
+1 −1 | tests/win_utils.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably ok without deprecating first because it hasn't reached 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, given the scope of the changes in this PR it seems like an appropriate time to remove these APIs ahead of the major version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summarizing the reason with a few words and perhaps linking to https://develop.sentry.dev/sdk/miscellaneous/hub_and_scope_refactoring/ could make the breaking change easier to accept for those who'll be affected 😉