Add native local scope for Windows/Linux #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…y-unreal into feat/local-scope-desktop
|
Awesome Stuff! (Non helpful but hopefully encouraging comment) |
jpnurmi
reviewed
May 29, 2025
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.cpp
Show resolved
Hide resolved
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.cpp
Show resolved
Hide resolved
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentryScope.cpp
Outdated
Show resolved
Hide resolved
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 2, 2025
This PR updates the Unreal Engine SDK docs to reflect recent changes that were made in getsentry/sentry-unreal#928. Specifically, `ConfigureScope` function was removed so now users can modify scope either via dedicated methods of `SentrySubsystem` class (for global scope) or by using a corresponding callback parameter that is available for all `capture` methods to add data for one specific event (local scope).
# Conflicts: # sample/Content/UI/W_SentryDemo.uasset
# Conflicts: # modules/sentry-native
jpnurmi
approved these changes
Jun 6, 2025
CHANGELOG.md
Outdated
Comment on lines
7
to
8
| - `Environment` and `Dist` get/set functions were removed from the `Scope` class and now these properties have to be set in plugin settings instead. | ||
| - `ConfigureScope` function was removed from `SentrySubsystem` class. |
There was a problem hiding this comment.
this is probably ok without deprecating first because it hasn't reached 1.0.0?
There was a problem hiding this comment.
Yes, given the scope of the changes in this PR it seems like an appropriate time to remove these APIs ahead of the major version bump.
There was a problem hiding this comment.
Summarizing the reason with a few words and perhaps linking to https://develop.sentry.dev/sdk/miscellaneous/hub_and_scope_refactoring/ could make the breaking change easier to accept for those who'll be affected 😉
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
This PR updates the Unreal Engine SDK docs to reflect recent changes that were made in getsentry/sentry-unreal#928. Specifically, `ConfigureScope` function was removed so now users can modify scope either via dedicated methods of `SentrySubsystem` class (for global scope) or by using a corresponding callback parameter that is available for all `capture` methods to add data for one specific event (local scope).
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
This PR updates the Unreal Engine SDK docs to reflect recent changes that were made in getsentry/sentry-unreal#928. Specifically, `ConfigureScope` function was removed so now users can modify scope either via dedicated methods of `SentrySubsystem` class (for global scope) or by using a corresponding callback parameter that is available for all `capture` methods to add data for one specific event (local scope).
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 12, 2025
Key Changes: - Updated some C++ examples to use `FSentryVariant` type instead of string (getsentry/sentry-unreal#971) - Added notice about using local scopes on Windows/Linux (getsentry/sentry-unreal#928) - Fixed supported platforms for screenshot feature
tustanivsky
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Aug 29, 2025
This PR adds Unreal Engine SDK migration guide for the upcoming `1.0.0` plugin release. Related to: - getsentry/sentry-unreal#928 - getsentry/sentry-unreal#971 - getsentry/sentry-unreal#1051 - getsentry/sentry-unreal#1018 - getsentry/sentry-unreal#886 - getsentry/sentry-unreal#745 - getsentry/sentry-unreal#436 - getsentry/sentry-unreal#589 - getsentry/sentry-unreal#1057 - getsentry/sentry-unreal#669 --------- Co-authored-by: Bruno Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the local scope implementation changes for
sentry-nativediscussed in getsentry/sentry-native#1226.Instead of applying scope data to each outgoing event via the
before_sendhandler, the SDK now uses a write-onlysentry_scope_tinstance which is then passed to the newsentry_capture_event_with_scopefunction. Also, with this approach global scope can be modified directly via native's API (tags, level, etc.) which addresses the issue with missing context values for fast-fail crashes.Breaking changes:
DistandEnvironmentproperties are now set during the SDK initialization via options, no more corresponding set/get functions inScopeclass.ConfigureScopefunction and it's a no-op on Win/Linux anyway it was removed fromUSentrySubsystem.Note: adding breadcrumbs via
sentry_add_breadcrumbto global scope unblocks further work on getsentry/sentry-native#1166 as custom handling for the corresponding event in Unreal plugin is no longer required.Docs update - getsentry/sentry-docs#13872