feat(events): GPU interface #10162
Merged
feat(events): GPU interface #10162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create tag for GPU name and vendor
HazAT
requested changes
Oct 17, 2018
bruno-garcia
force-pushed
the
feature/gpu-context-inf
branch
from
8db450b to
6eb6f0b
Compare
bruno-garcia
added a commit
to getsentry/sentry-unity
that referenced
this pull request
Oct 17, 2018
relies on getsentry/sentry#10162
mitsuhiko
approved these changes
Oct 17, 2018
|
@mitsuhiko you are right. Although fixed still looks a bit odd:
|
markstory
reviewed
Oct 17, 2018
| knownData.unshift(['?Vendor Id', vendor_id]); | ||
| } | ||
|
|
||
| if (id > 0) { |
There was a problem hiding this comment.
This condition could be combined with the one above it.
There was a problem hiding this comment.
You just caught a bug there! I should be checking for: vendor_id .
This is due to Unity serialization not handling int?, so type is not nullable and 0 will be sent :
It will be the case until we get away from Unity.JsonUtility
HazAT
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
Although the Unity API is called
SystemInfo.graphicsDeviceVendorit seems to return the driver vendor instead.The
SystemInfo.graphicsDeviceNameAPI returns in a single string what we would expect to be vendor, name and version.The plan is to let the data come in and once we have a enough sample, write the normalization code to better display this.
Note that GPU context was added with the smallest priority:
https://github.com/getsentry/sentry/pull/10162/files#diff-af6a04783ec9ae8b4cff8f0437a50e46R240
This is relevant because in case an event came in with user, runtime, os and device, GPU wouldn't be visible.