feat(ui): Adapt user-feedback page to lightweight organization context #15551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
reviewed
Nov 13, 2019
src/sentry/static/sentry/app/components/lightWeightNoProjectMessage.tsx
Outdated
Show resolved
Hide resolved
davidenwang
force-pushed
the
feat/lightweight-user-feedback
branch
from
37fcfb1 to
32d314f
Compare
billyvg
reviewed
Nov 13, 2019
src/sentry/static/sentry/app/components/organizations/multipleProjectSelector.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/organizations/headerItem.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/organizations/multipleEnvironmentSelector.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/organizations/multipleProjectSelector.jsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Nov 13, 2019
markstory
reviewed
Nov 13, 2019
src/sentry/static/sentry/app/components/organizations/multipleEnvironmentSelector.jsx
Outdated
Show resolved
Hide resolved
billyvg
approved these changes
Nov 13, 2019
davidenwang
force-pushed
the
feat/lightweight-user-feedback
branch
from
5f4072d to
9a0096f
Compare
jan-auer
added a commit
that referenced
this pull request
Nov 13, 2019
* master: (59 commits) fix(btn-group-break): quick fix for issues table nav items (#15585) feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345) ref: Update semaphore to 0.4.61 (#15574) fix(api): Fix failing snuba test in Django 1.9 chore(ts): convert sentry app component files (#15575) build(github-actions): RIP github actions (#15577) feat(ui): Adapt user-feedback page to lightweight organization context (#15551) ref(logo replacement): converted pngs to svgs (#15552) Remove unused animated-ellipsis (#15515) fix: Fix `get_participants` to use `__in` correctly. build(webpack): Remove `lodash-webpack-plugin` (#15521) moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468) ref: Remove "store.save-event-skips-nodestore" option from code (#15568) logging(app-context): adds more logging context for slack api errors (#15557) build(babel): Remove `@babel/polyfill` (#15564) chore(ts): convert sentryApps (#15565) chore(ts): convert SentryAppIcon (#15569) fix: Avoid updating with None (#15549) feat(api): Project key creation rate limit params (#15366) fix(api): Fix failing snuba test in Django 1.9 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the user-feedback page to the lightweight organization context (without projects/teams) to improve first time (cold start) load of the page. This should contribute to a large performance benefit to this page as teams and projects are both not required to show information on the user-feedback page. In order to do this I
This is what the loading state looks like:
