Skip to content

feat(ui): Adapt user-feedback page to lightweight organization context #15551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2019

Conversation

davidenwang
Copy link
Contributor

@davidenwang davidenwang commented Nov 12, 2019

Moving the user-feedback page to the lightweight organization context (without projects/teams) to improve first time (cold start) load of the page. This should contribute to a large performance benefit to this page as teams and projects are both not required to show information on the user-feedback page. In order to do this I

  • Introduced a loading state to GlobalSelectionHeader
  • Made the GlobalSelectionHeader listen to the loading flag surfaced by withProjects HOC
  • Replaced NoProjectMessage with a LightWeightNoProjectMessage that does not rely on projects to exist within organization

This is what the loading state looks like:
image

@davidenwang davidenwang self-assigned this Nov 12, 2019
@davidenwang davidenwang removed the WIP label Nov 12, 2019
@davidenwang davidenwang requested review from billyvg and a team November 12, 2019 23:59
@davidenwang davidenwang force-pushed the feat/lightweight-user-feedback branch from 37fcfb1 to 32d314f Compare November 13, 2019 00:40
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clicked around and this feels pretty good.

@davidenwang davidenwang force-pushed the feat/lightweight-user-feedback branch from 5f4072d to 9a0096f Compare November 13, 2019 19:35
@davidenwang davidenwang merged commit 9792fc6 into master Nov 13, 2019
@davidenwang davidenwang deleted the feat/lightweight-user-feedback branch November 13, 2019 20:00
jan-auer added a commit that referenced this pull request Nov 13, 2019
* master: (59 commits)
  fix(btn-group-break): quick fix for issues table nav items (#15585)
  feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
  ref: Update semaphore to 0.4.61 (#15574)
  fix(api): Fix failing snuba test in Django 1.9
  chore(ts): convert sentry app component files (#15575)
  build(github-actions): RIP github actions (#15577)
  feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
  ref(logo replacement): converted pngs to svgs (#15552)
  Remove unused animated-ellipsis (#15515)
  fix: Fix `get_participants` to use `__in` correctly.
  build(webpack): Remove `lodash-webpack-plugin` (#15521)
  moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
  ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
  logging(app-context): adds more logging context for slack api errors (#15557)
  build(babel): Remove `@babel/polyfill` (#15564)
  chore(ts): convert sentryApps (#15565)
  chore(ts): convert SentryAppIcon (#15569)
  fix: Avoid updating with None (#15549)
  feat(api): Project key creation rate limit params (#15366)
  fix(api): Fix failing snuba test in Django 1.9
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants