Skip to content

chore(ts): convert sentry app component files #15575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Nov 13, 2019

Also converted promises into async/await

@scefali scefali requested a review from a team November 13, 2019 18:16
type SentryAppComponentsStoreType = Reflux.Store & {
onLoadComponents: (items: SentryAppComponent[]) => void;
getComponentByType: (type: string | undefined) => SentryAppComponent[];
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a few others that could be typed, get and getAll?

@scefali scefali merged commit 253559f into master Nov 13, 2019
@scefali scefali deleted the scefali/chorets-convert-sentry-app-components branch November 13, 2019 20:25
jan-auer added a commit that referenced this pull request Nov 13, 2019
* master: (59 commits)
  fix(btn-group-break): quick fix for issues table nav items (#15585)
  feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345)
  ref: Update semaphore to 0.4.61 (#15574)
  fix(api): Fix failing snuba test in Django 1.9
  chore(ts): convert sentry app component files (#15575)
  build(github-actions): RIP github actions (#15577)
  feat(ui): Adapt user-feedback page to lightweight organization context (#15551)
  ref(logo replacement): converted pngs to svgs (#15552)
  Remove unused animated-ellipsis (#15515)
  fix: Fix `get_participants` to use `__in` correctly.
  build(webpack): Remove `lodash-webpack-plugin` (#15521)
  moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468)
  ref: Remove "store.save-event-skips-nodestore" option from code (#15568)
  logging(app-context): adds more logging context for slack api errors (#15557)
  build(babel): Remove `@babel/polyfill` (#15564)
  chore(ts): convert sentryApps (#15565)
  chore(ts): convert SentryAppIcon (#15569)
  fix: Avoid updating with None (#15549)
  feat(api): Project key creation rate limit params (#15366)
  fix(api): Fix failing snuba test in Django 1.9
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants