Skip to content

feat(demo-mode) also sync ProjectDebugFile and ProguardArtifactRelease #92731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

constantinius
Copy link
Contributor

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 85.18519% with 12 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/demo_mode/tasks.py 75.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #92731       +/-   ##
===========================================
+ Coverage   46.20%   87.92%   +41.71%     
===========================================
  Files       10242    10268       +26     
  Lines      587290   589893     +2603     
  Branches    22826    22826               
===========================================
+ Hits       271367   518647   +247280     
+ Misses     315477    70800   -244677     
  Partials      446      446               

Copy link
Member

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd rename this task to something like sync_debug_artifacts and introduce 3 sub functions like:
_sync_artifact_bundles(source, target), _sync_debug_files_(source, target), _sync_proguard_files(source, target)

Otherwise LGTM! 🚀

Dedicated  functions for project debug files and proguard artifact releases.
Making sure that project debug files within proguard releases are always synced if not yet done
@constantinius constantinius marked this pull request as ready for review June 4, 2025 15:32
@constantinius constantinius enabled auto-merge (squash) June 5, 2025 07:36
@constantinius constantinius merged commit 067aafe into master Jun 5, 2025
60 checks passed
@constantinius constantinius deleted the constantinius/feat/demo-mode/sync-debugfiles-proguard branch June 5, 2025 07:53
Copy link

sentry-io bot commented Jun 5, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ProgrammingError: UndefinedTable('relation "sentry_project" does not exist\nLINE 1: ...ile"."project_id" IN (SELECT U0."id" AS "id" FROM "sentry_pr...\n ^\n') sentry.demo_mode.tasks.sync_debug_artifacts View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants