-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(demo-mode) also sync ProjectDebugFile and ProguardArtifactRelease #92731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(demo-mode) also sync ProjectDebugFile and ProguardArtifactRelease #92731
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92731 +/- ##
===========================================
+ Coverage 46.20% 87.92% +41.71%
===========================================
Files 10242 10268 +26
Lines 587290 589893 +2603
Branches 22826 22826
===========================================
+ Hits 271367 518647 +247280
+ Misses 315477 70800 -244677
Partials 446 446 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd rename this task to something like sync_debug_artifacts
and introduce 3 sub functions like:
_sync_artifact_bundles(source, target)
, _sync_debug_files_(source, target)
, _sync_proguard_files(source, target)
Otherwise LGTM! 🚀
Dedicated functions for project debug files and proguard artifact releases. Making sure that project debug files within proguard releases are always synced if not yet done
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes https://linear.app/getsentry/issue/TET-528/extend-demo-mode-sync-task-to-handle-debug-files-and-proguard