Skip to content

fix(demo-mode): cleanup demo-mode sync options #92918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 10, 2025

Conversation

constantinius
Copy link
Contributor

@constantinius constantinius commented Jun 5, 2025

Closes https://linear.app/getsentry/issue/TET-439/clean-up-sync-artifact-bundle-options

Incorporates #92731

Removing lookback_days option

Moving options under the sentry.demo_mode.sync_debug_artifacts namespace

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 5, 2025
@constantinius constantinius changed the base branch from constantinius/feat/demo-mode/sync-debugfiles-proguard to master June 5, 2025 07:27
@constantinius constantinius requested a review from a team June 5, 2025 07:28
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/demo_mode/tasks.py 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92918      +/-   ##
==========================================
+ Coverage   87.89%   87.92%   +0.02%     
==========================================
  Files       10283    10299      +16     
  Lines      590346   591710    +1364     
  Branches    22951    22951              
==========================================
+ Hits       518911   520282    +1371     
+ Misses      70988    70981       -7     
  Partials      447      447              

@constantinius constantinius merged commit 5cbe978 into master Jun 10, 2025
62 checks passed
@constantinius constantinius deleted the constantinius/fix/demo-mode/cleanup-sync-options branch June 10, 2025 12:11
jan-auer added a commit that referenced this pull request Jun 10, 2025
* master:
  Revert "ref(spans): Pin redis sharding to partition index (#93209)"
  chore: add DemoModeGuardMiddleware logging (#92926)
  feat(tempest): Dynamically fetch ip addresses (#93012)
  fix(demo-mode): cleanup demo-mode sync options (#92918)
  ref(sdk): Migrate to `sentry_sdk.get_global_scope` (#93020)
  ref(sdk): Migrate to `get_isolation_scope` (#93019)
  ref(spans): Pin redis sharding to partition index (#93209)
Copy link

sentry-io bot commented Jun 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Project.DoesNotExist: Project matching query does not exist. sentry.demo_mode.tasks.sync_debug_artifacts View Issue
  • ‼️ ProjectArtifactBundle.DoesNotExist: ProjectArtifactBundle matching query does not exist. sentry.demo_mode.tasks.sync_debug_artifacts View Issue
  • ‼️ ProjectArtifactBundle.DoesNotExist: ProjectArtifactBundle matching query does not exist. sentry.demo_mode.tasks.sync_debug_artifacts View Issue
  • ‼️ ProjectArtifactBundle.DoesNotExist: ProjectArtifactBundle matching query does not exist. sentry.demo_mode.tasks.sync_debug_artifacts View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants