-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(demo-mode): cleanup demo-mode sync options #92918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
constantinius
merged 15 commits into
master
from
constantinius/fix/demo-mode/cleanup-sync-options
Jun 10, 2025
Merged
fix(demo-mode): cleanup demo-mode sync options #92918
constantinius
merged 15 commits into
master
from
constantinius/fix/demo-mode/cleanup-sync-options
Jun 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedicated functions for project debug files and proguard artifact releases. Making sure that project debug files within proguard releases are always synced if not yet done
…tifacts namespace
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92918 +/- ##
==========================================
+ Coverage 87.89% 87.92% +0.02%
==========================================
Files 10283 10299 +16
Lines 590346 591710 +1364
Branches 22951 22951
==========================================
+ Hits 518911 520282 +1371
+ Misses 70988 70981 -7
Partials 447 447 |
…into constantinius/fix/demo-mode/cleanup-sync-options
… need to be serialized
vgrozdanic
reviewed
Jun 5, 2025
…ed the discussion around it
vgrozdanic
approved these changes
Jun 10, 2025
jan-auer
added a commit
that referenced
this pull request
Jun 10, 2025
* master: Revert "ref(spans): Pin redis sharding to partition index (#93209)" chore: add DemoModeGuardMiddleware logging (#92926) feat(tempest): Dynamically fetch ip addresses (#93012) fix(demo-mode): cleanup demo-mode sync options (#92918) ref(sdk): Migrate to `sentry_sdk.get_global_scope` (#93020) ref(sdk): Migrate to `get_isolation_scope` (#93019) ref(spans): Pin redis sharding to partition index (#93209)
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/TET-439/clean-up-sync-artifact-bundle-options
Incorporates #92731
Removinglookback_days
optionMoving options under the
sentry.demo_mode.sync_debug_artifacts
namespace