logs: fix mingw-like builds (fixes #2898) #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you want the |
|
What I mean is, instead of checking for Windows or MinGW or using this LOG_COMPAT macro, just check for MSVC. It's a compiler problem, not an OS problem - _WIN32 has nothing to do with it, and the code shouldn't care whether it's gcc on Linux or Windows. |
cebtenzzre
requested changes
Aug 30, 2023
cebtenzzre
approved these changes
Aug 30, 2023
|
@cebtenzzre should I add fix for #2940 here ? It's quite simple. |
ggerganov
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2898
UsingBetter and simpler Windows detection via_WIN32does not work with mingw and similar build environments, and check for__MINGW32__is necessary in that case._MSC_VER.If mingw/msys like build environments are supported, this should probably get fixed in other parts of the project too, because currently it produces compile warnings.
Edit:
Fixes #2940 too.